Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always allow to close the error overlay #3624

Merged
merged 1 commit into from
Feb 3, 2023
Merged

always allow to close the error overlay #3624

merged 1 commit into from
Feb 3, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 3, 2023

It's difficult to test an app, if a single error blocks using the whole page.

Therefore, error overlay should always be closeable.

@sokra sokra requested a review from a team as a code owner February 3, 2023 17:16
@vercel
Copy link

vercel bot commented Feb 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 3, 2023 at 5:16PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:16PM (UTC)

@sokra sokra merged commit d240894 into main Feb 3, 2023
@sokra sokra deleted the sokra/error-overlay-close branch February 3, 2023 18:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Benchmark for 28a20a2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9841.09µs ± 67.16µs 9815.57µs ± 85.96µs -0.26%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9920.76µs ± 87.39µs 10.05ms ± 0.13ms +1.30%
bench_hmr_to_commit/Turbopack RSC/1000 modules 495.82ms ± 2.06ms 499.94ms ± 2.18ms +0.83%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9992.09µs ± 85.10µs 10.06ms ± 0.07ms +0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8845.92µs ± 84.80µs 8814.81µs ± 88.12µs -0.35%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9187.27µs ± 89.64µs 9099.16µs ± 81.78µs -0.96%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9068.49µs ± 61.00µs 9011.14µs ± 91.99µs -0.63%
bench_hydration/Turbopack RCC/1000 modules 5194.16ms ± 11.29ms 5244.13ms ± 23.14ms +0.96%
bench_hydration/Turbopack RSC/1000 modules 4680.20ms ± 16.54ms 4674.70ms ± 16.27ms -0.12%
bench_hydration/Turbopack SSR/1000 modules 4250.03ms ± 14.67ms 4210.70ms ± 14.08ms -0.93%
bench_startup/Turbopack CSR/1000 modules 3060.03ms ± 6.99ms 3065.86ms ± 21.37ms +0.19%
bench_startup/Turbopack RCC/1000 modules 3312.12ms ± 10.18ms 3308.28ms ± 7.89ms -0.12%
bench_startup/Turbopack RSC/1000 modules 3234.01ms ± 8.60ms 3257.89ms ± 8.94ms +0.74%
bench_startup/Turbopack SSR/1000 modules 2541.76ms ± 5.80ms 2532.27ms ± 9.62ms -0.37%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests

See workflow summary for details

mehulkar pushed a commit that referenced this pull request Feb 3, 2023
@sokra @mehulkar
always allow to close the error overlay (#3624)
167b8be 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
always allow to close the error overlay (vercel/turborepo#3624)
73efba1 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
always allow to close the error overlay (vercel/turborepo#3624)
aa3422a 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
always allow to close the error overlay (vercel/turborepo#3624)
f682e73 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
always allow to close the error overlay (vercel/turborepo#3624)
aa2abcc 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
always allow to close the error overlay (vercel/turborepo#3624)
fc90e42 
It's difficult to test an app, if a single error blocks using the whole
page.

Therefore, error overlay should always be closeable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @ForsakenHarmony