always allow to close the error overlay (vercel/turborepo#3624)

It's difficult to test an app, if a single error blocks using the whole page. Therefore, error overlay should always be closeable.
vercel · Feb 3, 2023 · aa3422a · aa3422a
1 parent bb0977c
commit aa3422a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/next-swc/crates/next-core/js/src/overlay/internal/container/Errors.tsx b/packages/next-swc/crates/next-core/js/src/overlay/internal/container/Errors.tsx
@@ -182,7 +182,10 @@ export function Errors({ issues, errors }: ErrorsProps) {
   const hasServerError = readyErrors.some((err) =>
     ["server", "edge-server"].includes(getErrorSource(err.error) || "")
   );
-  const isClosable = !isLoading && !hasIssueWithError && !hasServerError;
+
+  // TODO for now it's already closable, but in future we might want to block users from using a broken app
+  // const isClosable = !isLoading && !hasIssueWithError && !hasServerError;
+  const isClosable = true;
 
   const defaultTab =
     hasIssueWithError || !hasErrors