Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add displayName for link #37653

Closed
wants to merge 1 commit into from
Closed

fix: add displayName for link #37653

wants to merge 1 commit into from

Conversation

u3u
Copy link

@u3u u3u commented Jun 13, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@SukkaW
Copy link
Contributor

SukkaW commented Jun 13, 2022

Duplicated with #37154?

@balazsorban44
Copy link
Member

Sounds like a duplicate, indeed. Thanks for the PR anyway! If you want to check out #37154, you can try our canary release which should include that PR.

@u3u u3u deleted the patch-1 branch June 22, 2022 06:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants