Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid anonymous function in next/link #37154

Merged
merged 3 commits into from
May 24, 2022
Merged

Conversation

stefanprobst
Copy link
Contributor

Avoid anonymous function in next/link so DevTools show Link instead of Anonymous:

Before:

Screenshot_20220524_123016

After:

Screenshot_20220524_122946

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

timneutkens
timneutkens previously approved these changes May 24, 2022
@ijjk
Copy link
Member

ijjk commented May 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js patch-1 Change
buildDuration 15.9s 16.2s ⚠️ +303ms
buildDurationCached 6.6s 6.3s -303ms
nodeModulesSize 494 MB 494 MB ⚠️ +58 B
Page Load Tests Overall increase ✓
vercel/next.js canary stefanprobst/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 4.061 3.949 -0.11
/ avg req/sec 615.58 633.14 +17.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.509 1.508 0
/error-in-render avg req/sec 1656.61 1657.97 +1.36
Client Bundles (main, webpack)
vercel/next.js canary stefanprobst/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary stefanprobst/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Diffs

Diff for _buildManifest.js
@@ -13,7 +13,7 @@ self.__BUILD_MANIFEST = {
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-478ba29a386d0870.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-14cc686179ced0b5.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fa584c92af7d6b54.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for link-HASH.js
@@ -191,7 +191,7 @@
           scroll: scroll
         });
       }
-      var Link = /*#__PURE__*/ _react.default.forwardRef(function(
+      var Link = /*#__PURE__*/ _react.default.forwardRef(function LinkComponent(
         props,
         forwardedRef
       ) {
Diff for link.html
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-14cc686179ced0b5.js"
+      src="/_next/static/chunks/pages/link-fa584c92af7d6b54.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js patch-1 Change
buildDuration 18s 17.5s -426ms
buildDurationCached 6.6s 6.1s -458ms
nodeModulesSize 494 MB 494 MB ⚠️ +58 B
Page Load Tests Overall increase ✓
vercel/next.js canary stefanprobst/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 4.079 4.105 ⚠️ +0.03
/ avg req/sec 612.94 609.08 ⚠️ -3.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.386 1.289 -0.1
/error-in-render avg req/sec 1803.84 1939.34 +135.5
Client Bundles (main, webpack)
vercel/next.js canary stefanprobst/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary stefanprobst/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js patch-1 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Diffs

Diff for _buildManifest.js
@@ -13,7 +13,7 @@ self.__BUILD_MANIFEST = {
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-478ba29a386d0870.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-14cc686179ced0b5.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fa584c92af7d6b54.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for link-HASH.js
@@ -191,7 +191,7 @@
           scroll: scroll
         });
       }
-      var Link = /*#__PURE__*/ _react.default.forwardRef(function(
+      var Link = /*#__PURE__*/ _react.default.forwardRef(function LinkComponent(
         props,
         forwardedRef
       ) {
Diff for link.html
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-14cc686179ced0b5.js"
+      src="/_next/static/chunks/pages/link-fa584c92af7d6b54.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Commit: cd04be8

@kodiakhq kodiakhq bot merged commit 1cd76b9 into vercel:canary May 24, 2022
@stefanprobst stefanprobst deleted the patch-1 branch May 24, 2022 16:28
@SukkaW SukkaW mentioned this pull request Jun 13, 2022
11 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants