Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure prerender-manifest contains all i18n revalidate values #21404

Merged
merged 6 commits into from
Jan 27, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 21, 2021

This insures we add entries for each locale version of a non-dynamic SSG page since they can have unique revalidate values. This requires a version bump in the prerender-manifest since the static routes now contain additional values which need to be handled separately.

Fixes: #21568

@ijjk

This comment has been minimized.

@ijjk ijjk dismissed a stale review via f528d9d January 27, 2021 01:49
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Jan 27, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
buildDuration 9.5s 9.9s ⚠️ +358ms
nodeModulesSize 75 MB 75 MB ⚠️ +1.43 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
/ failed reqs 0 0
/ total time (seconds) 1.923 1.856 -0.07
/ avg req/sec 1299.97 1347.25 +47.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.17 1.188 ⚠️ +0.02
/error-in-render avg req/sec 2137.43 2104.89 ⚠️ -32.54
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
buildDuration 11.5s 11.4s -77ms
nodeModulesSize 75 MB 75 MB ⚠️ +1.43 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
buildDuration 11.6s 12.2s ⚠️ +640ms
nodeModulesSize 75 MB 75 MB ⚠️ +1.43 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
/ failed reqs 0 0
/ total time (seconds) 1.914 1.948 ⚠️ +0.03
/ avg req/sec 1306.33 1283.62 ⚠️ -22.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.214 1.2 -0.01
/error-in-render avg req/sec 2059.64 2083.08 +23.44
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
597-7c719119..27b6.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-7a100..a392.js gzip 3.38 kB 3.38 kB
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js manifest/non-dynamic-i18n-ssg Change
index.html gzip 586 B 586 B
link.html gzip 592 B 592 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "YAgMxQH8aHKj7HQK4rVsP",
+        "buildId": "t5HF8TLfohM98R8ItySdY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_buildManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_ssgManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "YAgMxQH8aHKj7HQK4rVsP",
+        "buildId": "t5HF8TLfohM98R8ItySdY",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_buildManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_ssgManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "YAgMxQH8aHKj7HQK4rVsP",
+        "buildId": "t5HF8TLfohM98R8ItySdY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_buildManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YAgMxQH8aHKj7HQK4rVsP/_ssgManifest.js"
+      src="/_next/static/t5HF8TLfohM98R8ItySdY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 46470b4

@ijjk ijjk marked this pull request as ready for review January 27, 2021 05:48
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The prerender-manifest should have separate entries for non-dynamic SSG pages with i18n
2 participants