Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prerender-manifest should have separate entries for non-dynamic SSG pages with i18n #21568

Closed
ijjk opened this issue Jan 27, 2021 · 1 comment · Fixed by #21404
Closed

The prerender-manifest should have separate entries for non-dynamic SSG pages with i18n #21568

ijjk opened this issue Jan 27, 2021 · 1 comment · Fixed by #21404
Assignees
@ijjk
Milestone
iteration 16

Comments

@ijjk
Copy link
Member

ijjk commented Jan 27, 2021

Currently the prerender-manifest contains one entry for non-dynamic SSG pages that is not prefixed with the configured locales. This prevents different revalidate values that are locale specific from being provided. This also causes returning notFound: true for the default locale on a non-dynamic SSG page to cause values to be missing for the other paths.
@ijjk ijjk self-assigned this Jan 27, 2021
@ijjk ijjk mentioned this issue Jan 27, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #21404 Jan 27, 2021
@Timer Timer added this to the iteration 16 milestone Jan 27, 2021
kodiakhq bot pushed a commit that referenced this issue Jan 27, 2021
@ijjk
Ensure prerender-manifest contains all i18n revalidate values (#21404)
87ed37d 
This insures we add entries for each locale version of a non-dynamic SSG page since they can have unique revalidate values. This requires a version bump in the `prerender-manifest` since the static routes now contain additional values which need to be handled separately. 

Fixes: #21568
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 16
Development

Successfully merging a pull request may close this issue.

Ensure prerender-manifest contains all i18n revalidate values ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk