Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Update implementation for FUNCTION LOAD. #1484

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
BEFORE

String functionLoad(String code);
String functionLoadReplace(String code);

AFTER

String functionLoad(String code, bool replace);

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Update implementation for `FUNCTION LOAD`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Apply suggestions from code review

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>

* I HATE YOU SPOTLESS

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add missing update.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add missing update.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label May 28, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner May 28, 2024 23:28
@Yury-Fridlyand Yury-Fridlyand merged commit abd1f62 into valkey-io:main Jun 3, 2024
12 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/integ_yuryf_fload_update branch June 3, 2024 19:48
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Java: Update implementation for `FUNCTION LOAD`. (#315)

* Update implementation for `FUNCTION LOAD`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants