Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Update implementation for FUNCTION LOAD. #315

Merged
merged 5 commits into from
May 28, 2024
Merged

Java: Update implementation for FUNCTION LOAD. #315

merged 5 commits into from
May 28, 2024

Conversation

Yury-Fridlyand
Copy link

BEFORE

String functionLoad(String code);
String functionLoadReplace(String code);

AFTER

String functionLoad(String code, bool replace);

@Yury-Fridlyand
Update implementation for FUNCTION LOAD.
fdb65c1 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand and others added 4 commits May 28, 2024 12:41
@Yury-Fridlyand @aaron-congo
Apply suggestions from code review
cfeda0c 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
@Yury-Fridlyand
I HATE YOU SPOTLESS
cb52080 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Add missing update.
9c6aa56 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Add missing update.
8c77b37 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit cd0f7a0 into java/integ_yuryf_fload_update May 28, 2024
11 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/dev_yuryf_fload_update branch May 28, 2024 23:27
yipin-chen pushed a commit that referenced this pull request Jun 3, 2024
@Yury-Fridlyand @aaron-congo
Java: Update implementation for FUNCTION LOAD. (valkey-io#1484)
abd1f62 
Java: Update implementation for `FUNCTION LOAD`. (#315)

* Update implementation for `FUNCTION LOAD`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
@Yury-Fridlyand @aaron-congo @cyip10
Java: Update implementation for FUNCTION LOAD. (valkey-io#1484)
d75ba9b 
Java: Update implementation for `FUNCTION LOAD`. (#315)

* Update implementation for `FUNCTION LOAD`.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-congo aaron-congo aaron-congo approved these changes

@GumpacG GumpacG Awaiting requested review from GumpacG

@cyip10 cyip10 Awaiting requested review from cyip10

Assignees
No one assigned
Labels
java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @aaron-congo