Don't log sensitive user info in GLIDE code #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't log sensitive user info. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * CLIPPY I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
aaron-congo,
barshaul,
acarbonetto and
shohamazon
barshaul
requested changes
May 26, 2024
barshaul
reviewed
May 26, 2024
nihohit
reviewed
May 28, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
Added |
nihohit
reviewed
May 29, 2024
| ) | ||
| .into()), | ||
| _ => { | ||
| Err((ErrorKind::TypeError, "Could not convert value to boolean") |
There was a problem hiding this comment.
also, why is this (and below) a boolean and not JSON toggle?
There was a problem hiding this comment.
JSON.TOGGLE returns 0/1 being converted to bool or nil.
Not a mistake I suppose.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
nihohit
approved these changes
May 30, 2024
barshaul
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Small clean up to avoid logging sensitive user data - requests and responses.
https://github.com/Bit-Quill/glide-for-redis/actions/runs/9134317535/job/25119609032?pr=288#step:7:385
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.