Don't log sensitive user info in GLIDE code #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
GumpacG,
aaron-congo,
jonathanl-bq,
acarbonetto,
tjzhang-BQ,
cyip10 and
yipin-chen
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jonathanl-bq
approved these changes
May 22, 2024
| ) | ||
| .into()), | ||
| }, | ||
| ExpectedReturnType::MapOfStringToDouble => match value { | ||
| Value::Nil => Ok(value), | ||
| Value::Map(map) => { | ||
| let map_clone = map.clone(); |
There was a problem hiding this comment.
Glad we're finally getting rid of these nasty map clones. I've been trying to do this for a while without disturbing the existing error messages.
Yury-Fridlyand
merged commit c74a023
into
core/integ_yuryf_update_logging
46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small clean up to avoid logging sensitive user info - requests and responses.
https://github.com/Bit-Quill/glide-for-redis/actions/runs/9134317535/job/25119609032?pr=288#step:7:385