-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added countries to isPassportNumber. #1555
Conversation
MX, TH, NZ, LI, KZ, JM, MY
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 1776 1776
=========================================
Hits 1776 1776
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats @JuanFML for your first PR 🎉
LGTM !
This will be merged after our release rework PR #1553 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuanFML Can you fix conflicts?
@JuanFML -- pls fix the merge conflicts and we should be good to go. Thanks for your contribution! |
@profnandaa can i work on this as author is awol |
If the PR is really abandoned, we can still create a new one based on this and add @JuanFML as co-author. |
@fedeci when doing clean up of stale PR's, we don't create new nor delete the existing one. https://github.com/validatorjs/validator.js/wiki/Maintenance:-PR-Clean-Up |
The last step explicitly say create a new PR :) |
Cool. Noted.
…On Fri, Oct 8, 2021, 3:00 PM Federico Ciardi ***@***.***> wrote:
The last step explicitly say create a new PR :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVWPH7DPVBYUWH3E5J4CLDUF3MM7ANCNFSM4U3POVVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@ezkemboi yes we can do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the merge conflicts, will try fix them.
chore: fix merge conflicts for #1555 Co-authored-by: JuanFML <jfml_97@live.com>
chore: fix merge conflicts for #1555 Co-authored-by: Juan Medina <jfml_97@live.com>
included in the combined PR - #2164 |
Enlarged feat isPassportNumber #1288 : Added more countries into the list
Added the next countries with their corresponding tests:
Checklist