Add option to set fetcherName for Tika >= 2.0.0
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Tika >= 2.0.0, fetching remote files via the server is done using so called [fetchers](https://cwiki.apache.org/confluence/display/TIKA/tika-pipes). If you are running a Tika Server that is configured to use an HTTP fetcher, you need the client to tell the server which fetcher to use, which is done by adding the HTTP header `fetcherName` to the request. Furthermore, the URL of the remote file to be fetched must be passed using a `fetchKey` header instead `fetchUrl` as in Tika 1.x.x. This adds a public API method to set the fetcher name, and replaces the `fileUrl` header with `fetcherName` and `fetchKey` if a fetcher name is set. If no fetcher name is set, the `fileUrl` header is still added to the request as usual to keep TIKA 1.x.x compatibility.
|
Thanks @relthyg, please give me a few days to take a look to these Tika feature and your changes. It looks OK but I'm working on the 2.0 version of this library and want to see how to integrate on it too... |
|
Thanks fore reaching out, @vaites. Let me know If I can do anything to help or improve the PR. |
|
Hey David, if there's anything that would help you – let me know. |
|
PR is merged and version v1.3.0 is published. Thanks for your contribution 👍 |
|
Thank you for accepting the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tika >= 2.0.0, fetching remote files via the server is done using so called fetchers. If you are running a Tika Server that is configured to use an HTTP fetcher, you need the client to tell the server which fetcher to use, which is done by adding the HTTP header
fetcherNameto the request. Furthermore, the URL of the remote file to be fetched must be passed using afetchKeyheader instead offetchUrlas in Tika 1.x.x.This adds a public API method to set the fetcher name, and replaces the
fileUrlheader withfetcherNameandfetchKeyif a fetcher name is set. If no fetcher name is set, thefileUrlheader is still added to the request as usual to keep TIKA 1.x.x compatibility.