Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limitation of fetcher names #34

Closed
mpdude opened this issue Aug 30, 2023 · 2 comments · Fixed by #35
Closed

Remove limitation of fetcher names #34

mpdude opened this issue Aug 30, 2023 · 2 comments · Fixed by #35

Comments

@mpdude
Copy link
Contributor

mpdude commented Aug 30, 2023

#33 added a way to set fetcher names for Tika 2.0. Fetcher names refer to configuration on the Tika server side where different implementations can retrieve the files to be processed via HTTP, from S3 and so on. Documentation is at https://cwiki.apache.org/confluence/display/TIKA/tika-pipes#tikapipes-Fetchers.

An example of how fetchers can be used when making requests is given in another section of the documentation, at https://cwiki.apache.org/confluence/display/TIKA/tika-pipes#tikapipes-FetchersInClassicServerEndpointsFetchersintheclassictika-serverendpoints.

As you can see, fetcher names may be arbitrary names that refer to configuration sections, and there may be multiple fetchers of the same type configured as well (for example, with different HTTP timeout values).

So, the artificial limitation of fetcher names added in 304f855 does not make sense. My suggestion is to remove it.

@mpdude
Copy link
Contributor Author

mpdude commented Aug 30, 2023

FYI @relthyg

@vaites
Copy link
Owner

vaites commented Aug 31, 2023

You are right. My approach is to always restrict argument values to avoid unexpected results, but here didn't understood the Tika feature. I tagged the 1.3.1 version with the PR merged.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants