Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Philippines holidays: add en_PH, en_US, fil, th localization #2093

Merged
merged 9 commits into from
Nov 2, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 30, 2024

Proposed change

  • Adds en_PH, en_US, fil, th localization for the Philippines holidays.
  • Update and Refractor test cases so that the end year is now 2050 like other entries.
  • "Ninoy Aquino Day" is now only added from 2004 onwards.

I'm not satisfied with Filipino/Tagalog localization myself, so any double-checks would be appreciated here i.e. I can't find proper words for Additional special (non-working) day since even local news use the English term as-is.

Edit 1: Some additional comments from a Filipino friend:

The last two entries ("Additional special (non-working) day" and "Elections special (non-working) day") can be translated to "Karagdagang Espesyal na Araw (Walang Trabajo)" and "Araw ng Halalan (Walang Trabajo)" respectively but that's awkward for me that is as the last two are normally written and said in English in all documentation.

Closes #2067 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b546a8) to head (51f8af7).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2093   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11549     11561   +12     
  Branches      1736      1739    +3     
=========================================
+ Hits         11549     11561   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius PPsyrius marked this pull request as ready for review October 31, 2024 04:16
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New localization 👍

holidays/countries/philippines.py Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/PH.po Outdated Show resolved Hide resolved
@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Oct 31, 2024

Looks like the new 2025 entries got announced as soon as I get to implement code review suggestions lol.

EDSA appears to be moved to WORKDAY category instead from 2025 onwards.

Also, Chinese New Year is mistakenly listed as Jan 9 instead of Jan 29 in the Philippines Public Holidays official list I think? I'll keep it as Jan 29 for now. The direct source appears to be correct

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
KJhellico
KJhellico previously approved these changes Oct 31, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, huge PH improvement. I'm not sure about their languages though:

README.rst Outdated Show resolved Hide resolved
@PPsyrius PPsyrius changed the title Update the Philippines holidays: add en_PH, en_US, th, tl localization Update the Philippines holidays: add en_PH, en_US, fil, th, tl localization Nov 1, 2024
@KJhellico
Copy link
Collaborator

KJhellico commented Nov 1, 2024

Meantime, in the Philippines: declaring Sunday, July 27, 2025, as a public holiday (special non-working day). 😉

BTW, it's special working holiday since 2009.

@PPsyrius PPsyrius changed the title Update the Philippines holidays: add en_PH, en_US, fil, th, tl localization Update the Philippines holidays: add en_PH, en_US, fil, th localization Nov 1, 2024
Copy link

sonarcloud bot commented Nov 2, 2024

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇵🇭 LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 2, 2024
Merged via the queue into vacanza:dev with commit edc8338 Nov 2, 2024
29 checks passed
@PPsyrius PPsyrius deleted the update_ph_holidays branch November 2, 2024 03:26
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filipino Localization for the Philippines Holiday Class
3 participants