-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Philippines holidays: add en_PH
, en_US
, fil
, th
localization
#2093
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2093 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 11549 11561 +12
Branches 1736 1739 +3
=========================================
+ Hits 11549 11561 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New localization 👍
Looks like the new 2025 entries got announced as soon as I get to implement code review suggestions lol. EDSA appears to be moved to
|
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, huge PH improvement. I'm not sure about their languages though:
en_PH
, en_US
, th
, tl
localizationen_PH
, en_US
, fil
, th
, tl
localization
Meantime, in the Philippines: declaring Sunday, July 27, 2025, as a public holiday (special non-working day). 😉 BTW, it's special working holiday since 2009. |
en_PH
, en_US
, fil
, th
, tl
localizationen_PH
, en_US
, fil
, th
localization
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇵🇭 LGTM
Proposed change
en_PH
,en_US
,fil
,th
localization for the Philippines holidays.I'm not satisfied with Filipino/Tagalog localization myself, so any double-checks would be appreciated here i.e. I can't find proper words for
Additional special (non-working) day
since even local news use the English term as-is.Edit 1: Some additional comments from a Filipino friend:
Closes #2067 .
Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally