-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support partial i18n in dashboard #8660
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
import './vaadin-dashboard-widget.js'; | ||
import './vaadin-dashboard-section.js'; | ||
import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js'; | ||
import type { I18nMixin, PartialI18n } from '@vaadin/component-base/src/i18n-mixin.js'; | ||
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin'; | ||
import { DashboardLayoutMixin } from './vaadin-dashboard-layout-mixin.js'; | ||
|
||
|
@@ -133,7 +134,7 @@ export interface DashboardCustomEventMap<TItem extends DashboardItem> { | |
|
||
export type DashboardEventMap<TItem extends DashboardItem> = DashboardCustomEventMap<TItem> & HTMLElementEventMap; | ||
|
||
export interface DashboardI18n { | ||
export type DashboardI18n = PartialI18n<{ | ||
selectWidget: string; | ||
selectSection: string; | ||
remove: string; | ||
|
@@ -147,7 +148,7 @@ export interface DashboardI18n { | |
moveApply: string; | ||
moveForward: string; | ||
moveBackward: string; | ||
} | ||
}>; | ||
|
||
/** | ||
* A responsive, grid-based dashboard layout component | ||
|
@@ -217,7 +218,7 @@ export interface DashboardI18n { | |
* @fires {CustomEvent} dashboard-item-resize-mode-changed - Fired when an item resize mode changed | ||
*/ | ||
declare class Dashboard<TItem extends DashboardItem = DashboardItem> extends DashboardLayoutMixin( | ||
ElementMixin(ThemableMixin(HTMLElement)), | ||
I18nMixin({} as DashboardI18n, ElementMixin(ThemableMixin(HTMLElement))), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the way the |
||
) { | ||
/** | ||
* An array containing the items of the dashboard | ||
|
@@ -243,10 +244,9 @@ declare class Dashboard<TItem extends DashboardItem = DashboardItem> extends Das | |
editable: boolean; | ||
|
||
/** | ||
* The object used to localize this component. | ||
* | ||
* To change the default localization, replace the entire | ||
* `i18n` object with a custom one. | ||
* The object used to localize this component. To change the default | ||
* localization, replace this with an object that provides all properties, or | ||
* just the individual properties you want to change. | ||
* | ||
* The object has the following structure and default values: | ||
* ``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtering for properties that the component uses doesn't bring much benefit, and is overridden when the dashboard element sets the i18n object on its children.