feat: support partial i18n in dashboard #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
commented
Feb 10, 2025
| const i18n = getDefaultI18n(); | ||
| return { | ||
| selectSection: i18n.selectSection, | ||
| remove: i18n.remove, | ||
| move: i18n.move, | ||
| moveApply: i18n.moveApply, | ||
| moveForward: i18n.moveForward, | ||
| moveBackward: i18n.moveBackward, | ||
| }; | ||
| return getDefaultI18n(); |
There was a problem hiding this comment.
Filtering for properties that the component uses doesn't bring much benefit, and is overridden when the dashboard element sets the i18n object on its children.
| @@ -217,7 +218,7 @@ export interface DashboardI18n { | |||
| * @fires {CustomEvent} dashboard-item-resize-mode-changed - Fired when an item resize mode changed | |||
| */ | |||
| declare class Dashboard<TItem extends DashboardItem = DashboardItem> extends DashboardLayoutMixin( | |||
| ElementMixin(ThemableMixin(HTMLElement)), | |||
| I18nMixin({} as DashboardI18n, ElementMixin(ThemableMixin(HTMLElement))), | |||
There was a problem hiding this comment.
With the way the Dashboard class is defined, applying the I18nMixin required some creativity.
web-padawan
approved these changes
Feb 11, 2025
|
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for partial I18N objects to dashboard. This allows setting an I18N object that only overrides some of the translations and uses default translations as fallback.
Type of change