Bug/42 circular dependencies #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we shouldn't generate webpack bundle into the vaadin-generated folder but rather to a separate folder... EDIT: done, it's now being generated directly in the build/resources/ somewhere. |
caalador
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Looks fine, @mehdi-vaadin was going to also get to know the plugin so he will also look this through.
caalador
previously requested changes
Feb 26, 2020
caalador
dismissed
their stale review
Fixed, but waiting another reviewers input
mehdi-vaadin
approved these changes
Feb 26, 2020
mstahv
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked vaadinBuildFrontend to be executed after the
classestask. Reconfigured the War/Jar task to package the created files in properly.