-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats.json not packaged to WAR #107
Comments
The reason that we can start the project without the stat.json is probably becaus Fusion adds the bundle into the index.html |
There is also a deeper issue here: the WAR file will package an older version of
|
So should the files just be directly created to |
Maybe.... I'm trying to remember the reason why we're using A fix could either be to generate stuff directly to
Let me investigate on this further. There's some info on this here: #44 |
Uh-oh, using
The But maybe it could be enough to only depend on |
Generating token file to |
That works! However, running Intellij+Tomcat will invoke Gradle to build the war file, which in turn will invoke |
Just as I suspected: Intellij+Tomcat ignores stuff present in The only way forward is to make |
Currently the
stats.json
is generated into thebuild/vaadin-generated/META-INF/VAADIN/config/
folder, along withflow-build-info.json
. However,stats.json
is generated after Gradle copies stuff frombuild/vaadin-generated
tobuild/resources/main
, thereforestats.json
file is not packaged. Vaadin is able to run withoutstats.json
both in dev and in production mode, however certain things will not work (for example PolymerTemplate and LitTemplate).Desktop (please complete the following information):
To Reproduce
TBD once the Gradle plugin 0.20.0.0.alpha3 is released.
Expected behavior
The
stats.json
is generated tobuild/resources/main
which will then cause Gradle to package it correctly to WAR.Additional context
The incorrect path can be seen in
webpack.generated.js
:PluginAdapterBase.servletResourceOutputDirectory()
returnsbuild/vaadin-generated/META-INF/VAADIN
PluginAdapterBase.webpackOutputDirectory()
returnsbuild/resources/main/META-INF/VAADIN/webapp/
Currently the
flow-build-info.json
is generated inbuild/vaadin-generated/META-INF/VAADIN/config/
(that is good); however is there a way to forcestats.json
to be generated elsewhere (inbuild/resources/main/META-INF/VAADIN/config/stats.json
)?The text was updated successfully, but these errors were encountered: