Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaadin-gradle-plugin 17.0.1 does not work with latest flow-server #100

Closed
stbischof opened this issue Dec 16, 2020 · 15 comments · Fixed by #105
Closed

vaadin-gradle-plugin 17.0.1 does not work with latest flow-server #100

stbischof opened this issue Dec 16, 2020 · 15 comments · Fixed by #105
Assignees
Labels
bug Something isn't working

Comments

@stbischof
Copy link

Desktop (please complete the following information):

  • Vaadin Plugin version: flowserver-latest SNAPSHOT and vaadin-gradle-plugin 17.0.1

Describe the bug
vaadin-gradle-plugin 17.0.1 does not work with newest snapshot version since vaadin/flow@bd84a1d

Caused by: java.lang.IllegalArgumentException: wrong number of arguments
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at com.vaadin.flow.server.webcomponent.WebComponentModulesWriter$DirectoryWriter.generateWebComponentsToDirectory(WebComponentModulesWriter.java:237)
        at com.vaadin.flow.server.frontend.FrontendWebComponentGenerator.generateWebComponents(FrontendWebComponentGenerator.java:85)
        at com.vaadin.flow.server.frontend.NodeTasks.<init>(NodeTasks.java:510)
        at com.vaadin.flow.server.frontend.NodeTasks.<init>(NodeTasks.java:46)
        at com.vaadin.flow.server.frontend.NodeTasks$Builder.build(NodeTasks.java:187)

@mvysny mvysny self-assigned this Dec 17, 2020
@mvysny mvysny added the bug Something isn't working label Dec 17, 2020
@mvysny
Copy link
Member

mvysny commented Dec 17, 2020

Hello, thank you for letting me know! Unfortunately I am unable to reproduce the issue on Vaadin 19.0.0.alpha1. I've pushed an example project to https://github.com/vaadin/base-starter-gradle/tree/master (the master branch) - running ./gradlew vaadinClean build appRun works for me and will start the app correctly.

Could you please post a zip of a project which fails to build for you?

@mvysny mvysny added the question Further information is requested label Dec 17, 2020
@mvysny
Copy link
Member

mvysny commented Dec 17, 2020

You're right! I've managed to reproduce the issue. Steps to reproduce:

  1. check out https://github.com/vaadin/base-starter-gradle/tree/master
  2. Build with ./gradlew -Pvaadin.productionMode.

@mvysny mvysny removed the question Further information is requested label Dec 17, 2020
@mvysny
Copy link
Member

mvysny commented Dec 17, 2020

I've proposed a much simplified maintenance scheme to the upstream: vaadin/flow#9685

@mvysny mvysny added the blocked by upstream Something needs to be fixed first in the depending libraries label Dec 17, 2020
@ollin
Copy link

ollin commented Mar 15, 2021

Hello, as far as I can see the vaadin/flow#9685 is solved. Do you have any plans when you can integrate the extracted part so that this bug goes away?

@mvysny
Copy link
Member

mvysny commented Mar 15, 2021

In fact yes. The flow ticket is going to be eventually merged into vaadin 20.alpha or such. When it does (or a bit before perhaps), I'll work on the support from the Gradle plugin side. However, the target for this is vaadin 20.

@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

A preliminary support for Vaadin 20 has been developed at https://github.com/vaadin/vaadin-gradle-plugin/tree/feature/vaadin20 . All tests pass, which is really encouraging. It is possible that the plugin will also work with Vaadin 19. I will test a bit today, then we can hopefully release. Stay tuned :)

@stbischof
Copy link
Author

This would have effect on the Plugin.
vaadin/flow#10319

@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

@stbischof sounds good! However, to keep track, could you please open a new bug report, explaining why it would be good to have such a config option? I will then track the PR and flow releases.

@stbischof
Copy link
Author

Is this one in flow enough
Or should i open an issues here?
vaadin/flow#10318

@mvysny mvysny removed the blocked by upstream Something needs to be fixed first in the depending libraries label Mar 18, 2021
@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

Please also open a ticket here, because the Gradle plugin then needs to expose the config setting in the Extension.

@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

We will release a new version of the plugin soonish (today), but there will be one known issue:

@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

PR: #105

@mvysny
Copy link
Member

mvysny commented Mar 18, 2021

Vaadin Gradle plugin 0.20.0.0.alpha3 has been released, enjoy 👍 I'm porting the example apps now.

@evan-miller-jumpmind
Copy link

I'm trying to use the unofficial version of the plugin (0.14.5.1) to build a Vaadin 14 application and I'm encountering this same issue. Would it be possible to fix it for this version as well, or are there any workarounds I can try?

@mvysny
Copy link
Member

mvysny commented May 12, 2021

Yes I've also encountered similar bug when building an app with plugin 0.14.5.1 and Vaadin 14.6.0. Could you open a new bug report in this regard please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants