-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vaadin-gradle-plugin 17.0.1 does not work with latest flow-server #100
Comments
Hello, thank you for letting me know! Unfortunately I am unable to reproduce the issue on Vaadin 19.0.0.alpha1. I've pushed an example project to https://github.com/vaadin/base-starter-gradle/tree/master (the master branch) - running Could you please post a zip of a project which fails to build for you? |
You're right! I've managed to reproduce the issue. Steps to reproduce:
|
I've proposed a much simplified maintenance scheme to the upstream: vaadin/flow#9685 |
Hello, as far as I can see the vaadin/flow#9685 is solved. Do you have any plans when you can integrate the extracted part so that this bug goes away? |
In fact yes. The flow ticket is going to be eventually merged into vaadin 20.alpha or such. When it does (or a bit before perhaps), I'll work on the support from the Gradle plugin side. However, the target for this is vaadin 20. |
A preliminary support for Vaadin 20 has been developed at https://github.com/vaadin/vaadin-gradle-plugin/tree/feature/vaadin20 . All tests pass, which is really encouraging. It is possible that the plugin will also work with Vaadin 19. I will test a bit today, then we can hopefully release. Stay tuned :) |
This would have effect on the Plugin. |
@stbischof sounds good! However, to keep track, could you please open a new bug report, explaining why it would be good to have such a config option? I will then track the PR and flow releases. |
Is this one in flow enough |
Please also open a ticket here, because the Gradle plugin then needs to expose the config setting in the Extension. |
We will release a new version of the plugin soonish (today), but there will be one known issue:
|
PR: #105 |
Vaadin Gradle plugin 0.20.0.0.alpha3 has been released, enjoy 👍 I'm porting the example apps now. |
I'm trying to use the unofficial version of the plugin (0.14.5.1) to build a Vaadin 14 application and I'm encountering this same issue. Would it be possible to fix it for this version as well, or are there any workarounds I can try? |
Yes I've also encountered similar bug when building an app with plugin 0.14.5.1 and Vaadin 14.6.0. Could you open a new bug report in this regard please? |
Desktop (please complete the following information):
Describe the bug
vaadin-gradle-plugin 17.0.1 does not work with newest snapshot version since vaadin/flow@bd84a1d
The text was updated successfully, but these errors were encountered: