Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Flow layout usage opt-out #2709

Closed
caalador opened this issue Sep 9, 2024 · 1 comment · Fixed by #2725
Closed

Make Flow layout usage opt-out #2709

caalador opened this issue Sep 9, 2024 · 1 comment · Fixed by #2725
Assignees
@caalador
Labels
enhancement New feature or request hilla Issues related to Hilla

Comments

@caalador
Copy link
Contributor

caalador commented Sep 9, 2024

Describe your motivation

When having available server side Layout and no react layout is defined we should automatically get the server side layout as long as the developer doesn't mark the view as no flow layout.

This will make the Layout feature work the same way as it does with Flow routes.

Describe the solution you'd like

When file-routes are generated we check routes without layout against available server layouts and add the "flowLayout": true flag into the file-routes.json so that the server side layout is used.

Describe alternatives you've considered

No response

Additional context

No response
@caalador caalador added enhancement New feature or request hilla Issues related to Hilla labels Sep 9, 2024
@caalador caalador self-assigned this Sep 9, 2024
caalador added a commit to vaadin/flow that referenced this issue Sep 9, 2024
@caalador
feat: generate layout.json
2a23488 
Genrate a layout.json for
Hilla to automatically
enable server layouts

part of vaadin/hilla#2709
@caalador
Copy link
Contributor Author

Will close vaadin/flow#19904

@caalador caalador mentioned this issue Sep 11, 2024
Merged
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
4c5ca39 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
@caalador caalador mentioned this issue Sep 11, 2024
Merged
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
0edbe92 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
13376da 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
81ab190 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
f3a11c7 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit that referenced this issue Sep 11, 2024
@caalador
feat: automtic flowLayout if match exists
6e1da97 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit that referenced this issue Sep 12, 2024
@caalador
feat: automtic flowLayout if match exists
9115328 
Automatically enable flowLayout
for views if a server layout
exists that matches, the flag
is not explicitly defined.

Closes #2709
caalador added a commit to vaadin/flow that referenced this issue Sep 13, 2024
@caalador
feat: generate layout.json (#19933)
e4a00ab 
Genrate a layout.json for
Hilla to automatically
enable server layouts

part of vaadin/hilla#2709
caalador added a commit to vaadin/docs that referenced this issue Sep 13, 2024
@caalador
fix: Update Flow-Hilla layout documentation
ecb7c53 
Update the documentation on Flow server
layout usage with hilla views.
Add since tag to respective parts.

Part of vaadin/hilla#2709
@caalador caalador mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
enhancement New feature or request hilla Issues related to Hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: automatic flowLayout if match exists vaadin/hilla
1 participant
@caalador