fix: Update Flow-Hilla layout documentation #3666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the documentation on Flow server layout usage with hilla views. Add since tag to respective parts. Part of vaadin/hilla#2709
github-actions
bot
added
the
Language unchecked
mshabarov
reviewed
Sep 24, 2024
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov
approved these changes
Sep 24, 2024
mshabarov
reviewed
Sep 27, 2024
| @@ -222,9 +222,11 @@ export default function Layout() { | |||
| ---- | |||
|
|
|||
| [[hilla-server-side-layout]] | |||
| [role="since:com.vaadin:vaadin@V24.5"] | |||
| == Flow Server Side Layout for Hilla Views | |||
There was a problem hiding this comment.
By the way, this chapter should give a link to https://vaadin.com/docs/latest/flow/advanced/menu-registry#creating-client-routes-menu-on-server to make it clear for readers how to create a dynamic menus. For hilla layouts it is mentioned, so should be the same for flow layout.
mshabarov
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation on Flow server
layout usage with hilla views.
Add since tag to respective parts.
Part of vaadin/hilla#2709
Closes #3662