Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned list builder parts in Chrome #11712

Closed
edler-san opened this issue Sep 5, 2019 · 10 comments
Closed

Misaligned list builder parts in Chrome #11712

edler-san opened this issue Sep 5, 2019 · 10 comments
Labels
BFP wontfix workaround Workaround provided in ticket comments

Comments

@edler-san
Copy link
Contributor

This is an issue with at least 8.8.6 and 8.9.0.beta3 as can be seen on https://demo.vaadin.com/sampler/#ui/data-input/multiple-value/list-builder

Chrome 76.0.3809.132 (Offizieller Build) (64-Bit) is used. Firefox is unaffected.
image

Especially in larger list this can render a complete UI useless (version 8.8.6 here)
image

@alexandru78
Copy link

same happens on vaadin 7

@TatuLund
Copy link
Contributor

TatuLund commented Sep 6, 2019

This looks like issue due some recent change in Chrome, there has not been changes in the code of this component lately, that could explain this.

@TatuLund TatuLund closed this as completed Sep 6, 2019
@TatuLund TatuLund reopened this Sep 6, 2019
@TatuLund
Copy link
Contributor

TatuLund commented Sep 6, 2019

For some reason the problem does not happen on my computer Windows 10, Chrome: Version 76.0.3809.132 (Official Build) (64-bit)

image

@knoobie
Copy link
Contributor

knoobie commented Sep 8, 2019

I could reproduce the misalignment with chromium on ubuntu. My windows 7 and MacOS didn't have the error.

@TatuLund
Copy link
Contributor

TatuLund commented Sep 8, 2019

I tested this with another Windows 10 PC with Chrome, and there the issue happens. This makes the problem really weird

image

Also I inspected the DOM with dev tools, and v-select-twincol-buttons does have correct styles, most importantly "vertical-align: top" is there, but Chrome just does not honor it in this case. Which makes the problem extremely hard to solve

image

@TatuLund
Copy link
Contributor

TatuLund commented Sep 8, 2019

There is an issue reported in Chromium bug tracker that seem to match the conditions of our observed issue

https://bugs.chromium.org/p/chromium/issues/detail?id=1001664&q=vertical-align&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

@TatuLund
Copy link
Contributor

TatuLund commented Sep 8, 2019

The ticket I linked has the following workaround "Disabling LayoutNG in chrome://flags returns correct behavior."

I tested the above hint on my computer, and it indeed seems to fix the problem.

@TatuLund TatuLund added workaround Workaround provided in ticket comments wontfix labels Sep 8, 2019
@jontto
Copy link
Contributor

jontto commented Sep 8, 2019

I can confirm that this workaround works for our Vaadin 8.8.6 based application also (although I don't like this workaround...)

@TatuLund
Copy link
Contributor

The Chromium ticket about this ticket has progressed swiftly, it states now "The fix in #c7 confirmed in 79.0.3909.0." So I am favoring to have this won't fix at Vaadin side and just wait for Chome 79 release, which will solve the issue.

@TatuLund
Copy link
Contributor

As there were comment in Chromium bug tracker "approved for merge to M78, branch:3904" I tested this today with Chrome 78 having LayoutNG enabled, and the problem seem to have disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFP wontfix workaround Workaround provided in ticket comments
Projects
None yet
Development

No branches or pull requests

6 participants