-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TwinColSelect broken on Edge in ValoThemeUI #9175
Comments
Hello there! It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
This issue is still valid for version 8.3.3, TwinColSelect is unusable on Edge. It is easily reproducible using Edge browser, just open any page with TwinColSelect in it. For example: https://demo.vaadin.com/sampler/#ui/data-input/multiple-value/list-builder When there are no items on one side, that side will have smaller height. |
What you mean by "unusable"? I can confirm that there is visual defect with Edge, but otherwise TwinColSelect is functional. I.e. you can select options from the left etc. |
I agree, "unusable" is bad choice of words. What I meant is that we can't deliver UI with visual defect like that to our customers. So our workaround is not using TwinColSelect, but implement our own using two ListSelect and buttons. |
For some reason with Edge, the "Selected options", style name "v-select-twincol-selections" is missing "vertical-align: top;". As a workaround you could try to add this to your theme. .v-select-twincol-selections { It should be inherited from .v-widget (which happens correctly in Chrome). It maybe issue in Valo theme somewhere, but that requires more investigation. |
I can confirm that your css workaround works, but only if you explicitly set height to TwinColSelect with setHeight() (not with setRows()!). As our components are mostly fixed width and height (in pixels), this is good enough for me. |
Hello there! We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
This is still an issue with 8.9.0.beta3 as can be seen on https://demo.vaadin.com/sampler/#ui/data-input/multiple-value/list-builder Especially in larger list this can render a complete UI useless (version 8.8.6 here) Chrome 76.0.3809.132 (Offizieller Build) (64-Bit) is used. |
@KyleRogers That is correct, that is why discussion was continued on different ticket. |
Hello there! We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet. There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too! |
In Edge, the ValoThemeUI?#!selects test's TwinColSelect looks broken:
Works as expected in Chrome on Windows
The text was updated successfully, but these errors were encountered: