Export src dir via cargo #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
added
enhancement
| @@ -3,6 +3,8 @@ name = "c2a-core" | |||
| version = "3.9.0-beta.6" | |||
| edition = "2021" | |||
|
|
|||
| links = "c2a-core" | |||
There was a problem hiding this comment.
元来はコンパイルした後にリンクするときの識別子．
C2A coreは（今は）linkできない（＝libビルドできない）ので，build.rsでの識別子としてしか使ってない
| @@ -6,6 +6,8 @@ use semver::Version; | |||
| use clang::{token::TokenKind::Punctuation, Clang, Index}; | |||
|
|
|||
| fn main() { | |||
| println!("cargo:source_dir={}", env!("CARGO_MANIFEST_DIR")); | |||
There was a problem hiding this comment.
env!("CARGO_MANIFEST_DIR")
がc2a-core本体がいるpath（で，これは予測不可能（cargoがcrateをあつめてbuildフォルダ？（まあ，ざっくりcrateがおいてある場所）に集める場所なので）
There was a problem hiding this comment.
で，そのディレクトリを cargo:source_dir （これはuser定義変数）として取得したい．
There was a problem hiding this comment.
println!("cargo:hoge= ...
は，cargoにhoge optionを ... として伝える機能
There was a problem hiding this comment.
hogeがcargoの知ってる変数であれば，cargoの挙動が変わる．
一方で，source_dirはcargoは知らない変数であり，かつ，この変数をcrateつかいたい側がこの変数をみたいことがある．
そのときにlinksがないと，参照できない
参照の仕方はこう
env::var("DEP_C2A_CORE_SOURCE_DIR").unwrap();
DEP_${links}_変数名
なのは仕様
meltingrabbit
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Cargo を経由して
c2a-corecrate のソースファイルのディレクトリを依存先の crate に公開するIssue/PR
詳細
影響範囲
c2a-corecrate のユーザー補足
リリースしたい