generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre Release (v3.9.0-beta.3): Packaging as Rust crate #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
changed the title
Packaging as crate
Pre Release (v3.9.0-beta.3): Packaging as crate
May 9, 2023
PR名 Packaging as Rust crate とかにしたくない?まだこのリポジトリ,Rustのコンテキストないからさ |
閉じはミス? |
ミス |
となると,c2a_core_main.h の define って存在意義なくなる?(Cのソースコード上で使いたいこともあるから,ひとまず残すしか無いか) |
あ,PR reopen したら on: pull_request って re-run するんだ Rust crate,若干不正確ではあるけど気持ちはわかるし,そうしてもまあ別によい |
meltingrabbit
changed the title
Pre Release (v3.9.0-beta.3): Packaging as crate
Pre Release (v3.9.0-beta.3): Packaging as Rust crate
May 9, 2023
普通にC言語側で使ってるからそんなことはない(ダブって面倒ではある) |
ちょっと文章変えた |
meltingrabbit
approved these changes
May 9, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
c2a-core を Rust の crate としてパッケージングする
詳細
c2a-core は現状あくまでC言語で書かれており,Rustのプロジェクト ではない が,Cargo などのエコシステムだけでも Rust のものに載せる価値は十分にある.
その前準備として,
Cargo.toml
だけを追加し,crate として公開する.影響範囲
リリースの手順が変わる.具体的には,バージョン番号を
Cargo.toml
でも管理するようにする.補足
Cargo.toml
も更新する必要があるので注意)備考