Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Release (v3.9.0-beta.4): CCP_DEST_TYPE_TO_APID を追加し,コマンドのルーティングを見直す #561

Merged
merged 4 commits into from
May 10, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented May 8, 2023

概要

CCP_DEST_TYPE_TO_APID を追加し,コマンドのルーティングを見直す

Issue

詳細

CCP_DEST_TYPE_TO_APID を追加し,APID の最終到達地点がキューイングの宛先の場合,個別に DEST_TYPE を設定することが不要になった

検証結果

既存のテストが全て通った

影響範囲

  • PH_user_analyze_cmd の書き換えが必要
  • MOBC にある 2nd OBC の driver の微修正が必要

備考

  • WINGS などの GS SW 側に影響があるので Pre Release を打つ
  • マージする前にバージョンを上げる

@meltingrabbit meltingrabbit added documentation Improvements or additions to documentation priority::high priorityg high labels May 8, 2023
@meltingrabbit meltingrabbit requested review from chutaro and flap1 May 8, 2023 15:39
@meltingrabbit
Copy link
Collaborator Author

@TomokiMochizuki cc @KOBA789 @ToshiAki64 @Yoshiki-Iwasa これによって,WINGS 側での dest type の設定がシンプルになります.

MOBC Queue が ON / OFF で dest type を 0x0 / 0xf を切り替えるだけで良くなり,コンポがなにかなどを気にする必要はなくなります.

@meltingrabbit meltingrabbit changed the title Pre Release (v3.9.0-beta.3): CCP_DEST_TYPE_TO_APID を追加し,コマンドのルーティングを見直す Pre Release (v3.9.0-beta.4): CCP_DEST_TYPE_TO_APID を追加し,コマンドのルーティングを見直す May 9, 2023
Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです

@meltingrabbit meltingrabbit force-pushed the feature/CCP_DEST_TYPE_TO_APID branch from d812c01 to 32ee432 Compare May 10, 2023 17:30
@meltingrabbit meltingrabbit merged commit d2532e8 into develop May 10, 2023
@meltingrabbit meltingrabbit deleted the feature/CCP_DEST_TYPE_TO_APID branch May 10, 2023 17:46
@meltingrabbit
Copy link
Collaborator Author

バージョン上げに失敗したので

でリカバリー

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority::high priorityg high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants