generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre Release (v3.8.0-beta.6): Use standard stdint.h #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
added
enhancement
New feature or request
priority::medium
priority medium
tools
labels
Mar 8, 2023
sksat
force-pushed
the
feature/use-std-stdint
branch
from
March 16, 2023 09:37
d03fd25
to
f85b539
Compare
meltingrabbit
changed the title
Use standard stdint.h
Use standard Pre Release (v3.8.0-beta.6): stdint.h
Mar 16, 2023
#520 がマージされて conflict してるので,rebase |
sksat
force-pushed
the
feature/use-std-stdint
branch
from
March 16, 2023 09:44
366f5a0
to
0c810ae
Compare
src_user/stdint.h x 2 を消すべき |
meltingrabbit
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそう
マージする前にバージョン上げてね |
meltingrabbit
changed the title
Use standard Pre Release (v3.8.0-beta.6): stdint.h
Pre Release (v3.8.0-beta.6): Use standard stdint.h
Mar 16, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
標準(C99)の
stdint.h
が存在する場合はできるだけ使うようにするIssue
NA
詳細
#include <stdint.h>
で C99stdint.h
相当 のヘッダが使えることを要求するC2A_USE_C99_STDINT
を追加し,default ON とするsrc_core/Library/stdint_wrapper/stdint.h
を追加するsrc_user/Library/stdint.h
は削除するsrc_user/Library/stdint_impl.h
に rename する#include <stdint.h>
して本物のstdint.h
が使えることが期待できる(仮にC89 指定したとしても)src_core/Library/stdint_wrapper/stdint.h
を使うsrc_core/Library/stdint_wrapper
を include path に加えるC2A_USE_C99_STDINT=OFF
を指定するとよいsrc_user/Library/stdint_impl.h
を使う(C2A user 側で提供する必要がある)SILS_FW
時は C99stdint.h
が使えることが期待できるので,使う背景
stdint.h
が標準規格に入ったのは C99 からなので,↑の環境のために C2A user 側でstdint.h
が提供されてきたsrc_user/Library/stdint.h
stdint.h
で定義されるような内容はビルドターゲットから一意に定まる内容であって,ビルド設定の一種stdint.h
が与える整数型は(当然)あらゆる場所で使うsrc_user/Library/stdint.h
への依存が多数発生している影響範囲
src_user/Library/stdint.h
)が必要な場合は,それを include directory にたす必要がある備考
この取り込みをuser側で使いたいため,pre releaseする