Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Release (v3.8.0-beta.5): DS に受信フレームの最大値の設定を追加 #508

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Pre Release (v3.8.0-beta.5): DS に受信フレームの最大値の設定を追加 #508

merged 5 commits into from
Mar 10, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Mar 1, 2023 •
edited
Loading

概要

Pre Release (v3.8.0-beta.5): DS に受信フレームの最大値の設定を追加

Issue

詳細

issue と driver_super.h で diff にでるコメントを参照

検証結果

CIとすべてのテストが通った

補足

  • DS の関数の順序を微修正 #507 を先にマージする
  • これで Driver Super, DS の大きな改修が一段落するので，Pre Release を打つ
  • したがって，マージする前にバージョンを上げる

@meltingrabbit meltingrabbit added enhancement New feature or request priority::medium priority medium labels Mar 1, 2023
@meltingrabbit meltingrabbit self-assigned this Mar 1, 2023
@meltingrabbit meltingrabbit mentioned this pull request Mar 1, 2023
Merged
@meltingrabbit meltingrabbit changed the title DS に受信フレームの最大値の設定を追加 Pre Release (v3.8.0-beta.): DS に受信フレームの最大値の設定を追加 Mar 3, 2023
@meltingrabbit meltingrabbit changed the title Pre Release (v3.8.0-beta.): DS に受信フレームの最大値の設定を追加 Pre Release (v3.8.0-beta.5): DS に受信フレームの最大値の設定を追加 Mar 3, 2023
@meltingrabbit meltingrabbit force-pushed the feature/fix_ds_small branch from da5f020 to 3b5d13e Compare March 4, 2023 06:19
@meltingrabbit meltingrabbit force-pushed the feature/max_rx_frame_size branch from cfe95ae to 280ea2e Compare March 4, 2023 06:19
@meltingrabbit meltingrabbit force-pushed the feature/fix_ds_small branch from 3b5d13e to cc32a26 Compare March 4, 2023 08:15
@meltingrabbit meltingrabbit mentioned this pull request Mar 9, 2023
Merged
Base automatically changed from feature/fix_ds_small to develop March 9, 2023 05:10
@meltingrabbit meltingrabbit force-pushed the feature/max_rx_frame_size branch from 280ea2e to 34d3519 Compare March 9, 2023 05:12
@meltingrabbit
Copy link
Collaborator Author

@chutaro レビュー指摘直しました．お願いします！

chutaro
chutaro reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

二点だけコメント入れてます、これ解決したら approve します

Drivers/Super/driver_super.c Outdated Show resolved Hide resolved
Drivers/Super/driver_super.c Show resolved Hide resolved
@meltingrabbit meltingrabbit merged commit 041feb6 into develop Mar 10, 2023
@meltingrabbit meltingrabbit deleted the feature/max_rx_frame_size branch March 10, 2023 00:01
@meltingrabbit
Copy link
Collaborator Author

リリース打ちました．

https://github.com/ut-issl/c2a-core/releases/tag/v3.8.0-beta.5

@meltingrabbit meltingrabbit mentioned this pull request Mar 10, 2023
Closed
@meltingrabbit meltingrabbit mentioned this pull request Mar 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutaro chutaro chutaro approved these changes

@flap1 flap1 Awaiting requested review from flap1

@ToshiAki64 ToshiAki64 Awaiting requested review from ToshiAki64

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @chutaro