Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC展開時刻被りはコマンド実行エラーにしないようにした #500

Merged
merged 3 commits into from
Apr 7, 2023
Merged

BC展開時刻被りはコマンド実行エラーにしないようにした #500

merged 3 commits into from
Apr 7, 2023

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented Feb 27, 2023 •
edited by meltingrabbit
Loading

概要

BC展開時刻被りはコマンド実行エラーにしないようにした

Issue

詳細

詳しくは issue

検証結果

pytest を手元で回して全て通った

@chutaro chutaro added the priority::medium priority medium label Feb 27, 2023
@chutaro chutaro self-assigned this Feb 27, 2023
@meltingrabbit
Copy link
Collaborator

キリ番

@meltingrabbit
Copy link
Collaborator

影響範囲大きそうかもなので，ちょっと時間ください

@chutaro
Copy link
Contributor Author

chutaro commented Feb 28, 2023

影響範囲大きそうかもなので，ちょっと時間ください

了解です。急ぎではないので大丈夫です！気持ちとしては、ISSL側では採用したいので可能なら v3.8 に入れ込みたいなという感じです

@meltingrabbit
Copy link
Collaborator

了解。
v4 の前に v3.9 挟んでもいいし、そこはよしなにやりましょう！

@meltingrabbit
Copy link
Collaborator

PL_deploy_block_cmd の返り値は変えてないので影響なさそうだった

@meltingrabbit
Copy link
Collaborator

あと，coreのバージョンあがってるので，rebaseもお願い

@chutaro chutaro force-pushed the feature/el_bc_deploy_time_adjusted branch from f786b64 to dc53852 Compare March 25, 2023 17:11
@chutaro
Copy link
Contributor Author

chutaro commented Mar 25, 2023

rebase もしました

meltingrabbit
meltingrabbit approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです！

v3.8.0 でちゃったので，すまんが再度rebaseたのみます

@chutaro chutaro force-pushed the feature/el_bc_deploy_time_adjusted branch from dc53852 to 5ee3b08 Compare April 5, 2023 07:36
@chutaro
Copy link
Contributor Author

chutaro commented Apr 5, 2023

rebase しました

@meltingrabbit
Copy link
Collaborator

@chutaro すでにapprove済みなのでマージOKよ？

@chutaro chutaro force-pushed the feature/el_bc_deploy_time_adjusted branch from 5ee3b08 to 2552383 Compare April 7, 2023 01:05
@chutaro chutaro merged commit 68f18ad into develop Apr 7, 2023
@chutaro chutaro deleted the feature/el_bc_deploy_time_adjusted branch April 7, 2023 01:27
@chutaro chutaro mentioned this pull request May 26, 2023
Merged
20 tasks
@meltingrabbit meltingrabbit mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@chutaro chutaro

Labels
priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chutaro @meltingrabbit