Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDISの実行エラーのEL登録のlocal id を cmd id にした #499

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented Feb 27, 2023

概要

CDISの実行エラーのEL登録のlocal id を cmd id にした

Issue

詳細

issueの通り。cmd id ごとに EL 登録を無効化したいというのが最大のモチベ。

検証結果

手元で修正したpytestを通した

@chutaro chutaro added the priority::medium priority medium label Feb 27, 2023
@chutaro chutaro self-assigned this Feb 27, 2023
@chutaro chutaro changed the title Draft: CDISの実行エラーのEL登録のlocal id を cmd id にした CDISの実行エラーのEL登録のlocal id を cmd id にした Feb 28, 2023
@chutaro chutaro force-pushed the feature/revise_cdis_el branch from 29ff014 to 1db7c5c Compare April 5, 2023 14:55
@chutaro
Copy link
Contributor Author

chutaro commented Apr 5, 2023

これ black で落ちても何が悪いかは教えてくれないんですね..

@meltingrabbit
Copy link
Collaborator

black,とくにオプションないからね.

black,バージョンあがってるから,手元のバージョンも最新にしておいてね(じゃないととおらないとおもう)

@chutaro

Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

@chutaro chutaro merged commit 8cf8f87 into develop Apr 7, 2023
@chutaro chutaro deleted the feature/revise_cdis_el branch April 7, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority::medium priority medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants