Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS Compile 1.2.0 #117

Merged
merged 60 commits into from
Sep 4, 2024
Merged

USWDS Compile 1.2.0 #117

merged 60 commits into from
Sep 4, 2024

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Aug 30, 2024

What's new in USWDS Compile 1.2.0

Features

Dependencies and security

Dependency name Previous version New version
autoprefixer 10.4.16 10.4.20
gulp 4.0.2 5.0.0
gulp-sourcemaps 3.0.0 --
postcss 8.4.31 8.4.40
sass-embedded 1.69.5 1.77.8
@uswds/uswds 3.7.0 3.8.1

0 vulnerabilities using npm audit.

Release TGZ SHA-256 hash: 53995f42af77dcf5a7f66e5adebeebf2742a662d3cf7a12587b38b22422db122

mejiaj and others added 30 commits November 27, 2023 12:27
USWDS-Compile - Dependencies: POAM Dec '23
USWDS-Compile - Dependencies: POAM March '24
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
USWDS-Compile - POAM: April '24
USWDS-Compile - README: Add staying up-to-date note.
USWDS-Compile - POAM: May '24
- Drop `gulp-sourcemaps` which is seemingly neglected and is the reason
  for 3 npm audit warnings. Gulp v4 and v5 have native support for
  toggling sourcemaps.
- Add new boolean setting `settings.compile.sassSourcemaps` that
  defaults to `true` but can be set to `false` in consumer projects to
  disable outputting sass sourcemaps.

This addresses the sass portion of #70. Exclusion of USWDS JS sourcemaps
would need a separate setting and handling.
USWDS-Compile - POAM: June '24
mahoneycm and others added 18 commits July 8, 2024 11:57
USWDS-Compile - Dependencies: GulpJS v5
USWDS-Compile - POAM: July '24
USWDS-Compile - Dependencies: Install optional dependencies for sass-embedded
USWDS-Compile - Gulp: Support disabling sass sourcemaps
USWDS-Compile - POAM: August '24
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.7 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.7...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Update Gulp reference to `Gulp 5`
…-4.0.8

Bump micromatch from 4.0.7 to 4.0.8
@thisisdano thisisdano requested review from mejiaj and amyleadem August 30, 2024 20:04
@thisisdano thisisdano marked this pull request as ready for review August 30, 2024 20:05
.snyk Outdated Show resolved Hide resolved
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! Just one open comment about the necessity of the .snyk file.

  • Confirmed I could successfully install, start, and run gulp commands with this branch in uswds-site with uswds v3 and uswds-sandbox with v2
  • Confirmed the content in the dependency tables in the PR description and release notes match the dependency changes in package.json
  • Confirmed the items tagged for 1.2.0 have been merged into develop and that this branch is up to date with develop
  • Confirmed all references to "Gulp 4" have been updated

@thisisdano
Copy link
Member Author

Made a change on this branch, so updated SHA 256 hash: 53995f42af77dcf5a7f66e5adebeebf2742a662d3cf7a12587b38b22422db122

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Confirmed .snyk was successfully removed and the SHA 256 hash in the .tgz matches the release notes.

@mahoneycm
Copy link
Contributor

RE: The snyk page, I know we don't have a script to run snyk tests on this repo but running npx snyk test does result in the following error:

image

Flagging in case we want to include snyk tests here

@thisisdano thisisdano merged commit a79c593 into main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants