Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Compile - Feature: Allow disabling sourcemaps #70

Closed
2 tasks done
rayestrada opened this issue Aug 10, 2023 · 2 comments · Fixed by #103
Closed
2 tasks done

USWDS-Compile - Feature: Allow disabling sourcemaps #70

rayestrada opened this issue Aug 10, 2023 · 2 comments · Fixed by #103
Assignees
@mejiaj
Labels
Affects: Compiling Related to compiling Sass or JavaScript Type: Feature Request New functionality
Milestone
compile 1.2.0

Comments

@rayestrada
Copy link

Is your feature request related to a problem? Please describe.

When using this tool in our USWDS + Drupal + static site generation setup the .map sourcemap files aren't copied over because they are comments in the css and not actual source file references. This causes the .map files to be listed as missing in the console. If we can conditionally disable sourcemaps as an option then we would not have missing files in the console log.

Describe the solution you'd like

Add an option to disable sourcemaps in the output css.

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct
@rayestrada rayestrada added the Type: Feature Request New functionality label Aug 10, 2023
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Aug 10, 2023
@mejiaj mejiaj added Affects: Compiling Related to compiling Sass or JavaScript and removed Status: Triage We're triaging this issue and grooming if necessary labels Aug 16, 2023
@mejiaj mejiaj self-assigned this Aug 16, 2023
@mejiaj mejiaj moved this from TBD to Ready to Schedule in USWDS Core Project Data Aug 16, 2023
@mejiaj mejiaj added this to the compile 1.2.0 milestone Nov 15, 2023
mdmower-csnw added a commit to mdmower-csnw/uswds-compile that referenced this issue Jun 5, 2024
@mdmower-csnw
Support disabling SASS sourcemaps
6fc585f 
- Drop gulp-sourcemaps is seemingly neglected and is the reason for 3
  npm audit warnings. Gulp v4 and v5 have native support for toggling
  sourcemaps.
- Add new boolean setting `settings.compile.sassSourcemaps` that
  defaults to `true` but can be set to `false` in consumer projects to
  disable outputting SCSS sourcemaps.

This addresses the SCSS portion of uswds#70. JS would need a separate
setting.
mdmower-csnw added a commit to mdmower-csnw/uswds-compile that referenced this issue Jun 5, 2024
@mdmower-csnw
Support disabling sass sourcemaps
2399c94 
- Drop `gulp-sourcemaps` which is seemingly neglected and is the reason
  for 3 npm audit warnings. Gulp v4 and v5 have native support for
  toggling sourcemaps.
- Add new boolean setting `settings.compile.sassSourcemaps` that
  defaults to `true` but can be set to `false` in consumer projects to
  disable outputting sass sourcemaps.

This addresses the sass portion of uswds#70. Exclusion of USWDS JS sourcemaps
would need a separate setting and handling.
@mdmower-csnw mdmower-csnw mentioned this issue Jun 5, 2024
Merged
@mejiaj mejiaj moved this from Ready to Schedule to Review in USWDS Core Project Data Jun 14, 2024
@amyleadem amyleadem moved this from Review to Fed Final Review in USWDS Core Project Data Jul 9, 2024
@amyleadem amyleadem moved this from Fed Final Review to Review in USWDS Core Project Data Jul 15, 2024
@amyleadem
Copy link
Contributor

Moving this issue back into "Review" status while we investigate the issue flagged in PR #103.

@amyleadem
Copy link
Contributor

Moving this back into "Fed final" since we have a proposed fix in #110

@amyleadem amyleadem moved this from Review to Fed Final Review in USWDS Core Project Data Jul 16, 2024
@github-project-automation github-project-automation bot moved this from Fed Final Review to Done in USWDS Core Project Data Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejiaj mejiaj

Labels
Affects: Compiling Related to compiling Sass or JavaScript Type: Feature Request New functionality
Projects
USWDS Core Project Data
Archived in project
Milestone
compile 1.2.0
Development

Successfully merging a pull request may close this issue.

USWDS-Compile - Gulp: Support disabling sass sourcemaps mdmower-csnw/uswds-compile
3 participants
@mejiaj @rayestrada @amyleadem