Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate anchors #362

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

JustKuzya
Copy link
Collaborator

@JustKuzya JustKuzya commented May 11, 2023

Committer Notes

Mostly fixes usnistgov/OSCAL#1681

Added transformations to build in anchors for deep-linking the h1-h6. This part of the Fix spread over repos. The second part is in foot.html and schema-docs.scss

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@JustKuzya JustKuzya changed the base branch from main to develop May 11, 2023 21:24
wendellpiez
wendellpiez previously approved these changes May 12, 2023
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice -- my only suggestions are a bit tighter syntax. Impressive job by @JustKuzya and @nikitawootten-nist on this work item.

Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks. I just have some few requested changes as it pertains to related changes explained in usnistgov/OSCAL#1789 (review).

Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some recommendations on aligning the comments that we want to keep. Also, we need to fix up the class names as discussed to align with usnistgov/OSCAL#1789 (review).

@aj-stein-nist
Copy link
Collaborator

@JustKuzya, did you get a chance to updated PR feedback? We will wrap up the sprint today so I wanted to know if we can close this out for this sprint or not.

@JustKuzya
Copy link
Collaborator Author

Added the changes suggested above

@JustKuzya
Copy link
Collaborator Author

Added suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statically generate anchor tags in model documentation
4 participants