-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate anchors #362
Generate anchors #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice -- my only suggestions are a bit tighter syntax. Impressive job by @JustKuzya and @nikitawootten-nist on this work item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks. I just have some few requested changes as it pertains to related changes explained in usnistgov/OSCAL#1789 (review).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some recommendations on aligning the comments that we want to keep. Also, we need to fix up the class names as discussed to align with usnistgov/OSCAL#1789 (review).
@JustKuzya, did you get a chance to updated PR feedback? We will wrap up the sprint today so I wanted to know if we can close this out for this sprint or not. |
Added the changes suggested above |
Added suggested changes |
Committer Notes
Mostly fixes usnistgov/OSCAL#1681
Added transformations to build in anchors for deep-linking the h1-h6. This part of the Fix spread over repos. The second part is in foot.html and schema-docs.scss
All Submissions:
Changes to Core Features: