Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Style for Generating Reference Model Anchors at Build Time #1789

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

JustKuzya
Copy link
Contributor

@JustKuzya JustKuzya commented May 11, 2023

Committer Notes

Partial fix for usnistgov/issue#1681

These two files hoos up anchors-js stuff for the older style deep-links at the recommended time in the event-lifecycle
Also makes sure that CSS hooks up behaviors to old site and ignores the newer versions.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist changed the title Jk s66/issue#1681 Update Style for Generating Reference Model Anchors at Build Time May 13, 2023
@aj-stein-nist aj-stein-nist requested a review from a team May 16, 2023 13:42
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, just some important but very minor feedback to make the class names more legible to me. Also, I have some follow-up questions about layover AnchorJS styles we will be removing.

docs/assets/scss/schema-docs.scss Outdated Show resolved Hide resolved
docs/assets/scss/schema-docs.scss Outdated Show resolved Hide resolved
docs/assets/scss/schema-docs.scss Outdated Show resolved Hide resolved
@aj-stein-nist aj-stein-nist linked an issue May 30, 2023 that may be closed by this pull request
6 tasks
@aj-stein-nist
Copy link
Contributor

@JustKuzya, did you get a chance to updated PR feedback? We will wrap up the sprint today so I wanted to know if we can close this out for this sprint or not.

@JustKuzya
Copy link
Contributor Author

JustKuzya commented May 30, 2023 via email

aj-stein-nist
aj-stein-nist previously approved these changes May 31, 2023
Copy link
Contributor Author

@JustKuzya JustKuzya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "hooked up" apparently is just one right-hand ring-finger flutter away from the "hooled up" :) My bad for not catching it before push

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustKuzya can you update the metaschema submodule to the current develop branch commit now that PR has been merged?

@aj-stein-nist
Copy link
Contributor

@JustKuzya can you update the metaschema submodule to the current develop branch commit now that PR has been merged?

Bump on this @JustKuzya, because we need the submodule moved up before I can approve and merge this (or I wouldn't keep bringing it up).

aj-stein-nist
aj-stein-nist previously approved these changes Jun 13, 2023
@aj-stein-nist
Copy link
Contributor

aj-stein-nist commented Jun 13, 2023

Sigh, how can we even get a merge conflict on pushing up a submodule!? I didn't notice this while pairing. I will have to investigate later.

@aj-stein-nist
Copy link
Contributor

The local performance metrics were dubious when run in a virtualized developer weird ways but Dmitry provided interim metrics (Site-Benchmarks.xlsx). Running hugo serve locally seems to have weird crashes even with Chrome Lighthouse running locally in weird ways I also encountered, so more to follow on that as we close out this issue.

@aj-stein-nist aj-stein-nist merged commit 68d5b38 into develop Jun 14, 2023
@aj-stein-nist aj-stein-nist deleted the jk-s66/Issue#1681 branch June 14, 2023 17:03
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
…nistgov#1789)

* isset Did not seem to work - changed it to ne (!= or <>)

* Second part of the Anchor-JS unhooking and static Anchor Generated

* hooled up the renamed class name .reference-element-anchor

* Adding metaschema submodule changes (fixed with merge conflict).
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
…nistgov#1789)

* isset Did not seem to work - changed it to ne (!= or <>)

* Second part of the Anchor-JS unhooking and static Anchor Generated

* hooled up the renamed class name .reference-element-anchor

* Adding metaschema submodule changes (fixed with merge conflict).
@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statically generate anchor tags in model documentation
2 participants