Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
Several tests were failing but due to incorrect
expect()
statements it wasn't being detected. I've added an eslint plugin to check that they're done right so thenpm run lint
task should catch any future ones. I was able to fix most of the tests to pass, I think I got the fixes right but it wouldn't hurt to have some more eyes on this.@jbalboni I couldn't figure out why this new test was failing, it's part of #267 which recently landed. I'm thinking it's due to the test rather than the code but can you take a look and let me know?
Types of changes
Checklist:
npm run lint
.npm run build
.npm test
.