Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad expect()ations in tests #284

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

dmethvin-gov
Copy link
Contributor

Fixes #227

Several tests were failing but due to incorrect expect() statements it wasn't being detected. I've added an eslint plugin to check that they're done right so the npm run lint task should catch any future ones. I was able to fix most of the tests to pass, I think I got the fixes right but it wouldn't hurt to have some more eyes on this.

@jbalboni I couldn't figure out why this new test was failing, it's part of #267 which recently landed. I'm thinking it's due to the test rather than the code but can you take a look and let me know?

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've reviewed the guidelines for contributing to this repository.
  • I've checked style and lint with npm run lint.
  • I built the production version with npm run build.
  • I added tests to verify a bug fix or new functionality.
  • All tests pass locally with npm test.
  • My change requires a change to the documentation, and I've updated the documentation accordingly.

Fixes usds#227

Several tests were failing but due to incorrect expect() statements it wasn't being detected.
Copy link
Contributor

@annekainicUSDS annekainicUSDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

@dmethvin-gov dmethvin-gov merged commit 702b179 into usds:master Sep 26, 2018
@dmethvin-gov dmethvin-gov deleted the fix-test-expects branch September 26, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check unit tests for unfinished expect() assertions
2 participants