Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check unit tests for unfinished expect() assertions #227

Closed
dmethvin-gov opened this issue Aug 16, 2018 · 1 comment · Fixed by #284
Closed

Check unit tests for unfinished expect() assertions #227

dmethvin-gov opened this issue Aug 16, 2018 · 1 comment · Fixed by #284
Labels
[practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues
Milestone
End of Phase 1

Comments

@dmethvin-gov
Copy link
Contributor

In doing some updates to the unit tests I couldn't figure out why some succeeded even when they should fail. Turned out they had just a bare expect(thing) rather than for example expect(thing).to.be.true so it wasn't testing a thing. The case I found was in SubmitController but it's a really easy mistake to make given the API and I found at least one other case in SchemaForm where the same thing happens. We should review and fix all the cases and may need to push some issues back to vets.gov as a courtesy if they've forked functionality.
@annekainicUSDS annekainicUSDS added the [practice] engineering Engineering related work label Aug 18, 2018
@jcmeloni-usds
Copy link
Contributor

Approved. :)

@jcmeloni-usds jcmeloni-usds added this to the End of Phase 1 milestone Sep 20, 2018
@jcmeloni-usds jcmeloni-usds added the [type] debt Tech debt, refactors, maintenance issues label Sep 24, 2018
dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Sep 24, 2018
@dmethvin-gov
Fix bad expect()ations in tests
5eb231f 
Fixes usds#227

Several tests were failing but due to incorrect expect() statements it wasn't being detected.
dmethvin-gov added a commit to dmethvin-gov/us-forms-system that referenced this issue Sep 24, 2018
@dmethvin-gov
Fix bad expect()ations in tests
1a1dab4 
Fixes usds#227

Several tests were failing but due to incorrect expect() statements it wasn't being detected.
@dmethvin-gov dmethvin-gov mentioned this issue Sep 24, 2018
Merged
9 tasks
dmethvin-gov added a commit that referenced this issue Sep 26, 2018
@dmethvin-gov
Fix bad expect()ations in tests (#284)
702b179 
Fixes #227

Several tests were failing but due to incorrect expect() statements it wasn't being detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues
Projects
None yet
Milestone
End of Phase 1
Development

Successfully merging a pull request may close this issue.

Fix bad expect()ations in tests dmethvin-gov/us-forms-system
3 participants
@jcmeloni-usds @annekainicUSDS @dmethvin-gov