Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sumo config setup fix #182

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix/sumo config setup fix #182

merged 4 commits into from
Nov 29, 2023

Conversation

EricChen-Lei
Copy link
Contributor

@EricChen-Lei EricChen-Lei commented Nov 29, 2023

PR Details

Description

Enhance behavior of the sumo traffic light for TRB scenario

Related GitHub Issue

Related Jira Key

CDAR-523

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MishkaMN MishkaMN merged commit d982819 into develop Nov 29, 2023
4 checks passed
@MishkaMN MishkaMN deleted the fix/sumo_config_setup_fix branch November 29, 2023 16:31
@MishkaMN
Copy link
Contributor

This PR is to let the additional 3 vehicles in the TRB scenario to always go by changing the traffic signal of their location to always green. This helps better tune the timings of the vehicles to produce the collision scenario we want to demonstrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants