Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove java #10

Merged
merged 2 commits into from
Oct 30, 2020
Merged

remove java #10

merged 2 commits into from
Oct 30, 2020

Conversation

MishkaMN
Copy link
Contributor

PR Details

Description

This PR is to remove the remaining java code in the system.

Related Issue

usdot-fhwa-stol/carma-platform#645

Motivation and Context

Please see the linked issue.

How Has This Been Tested?

Buildable and integration tested on cars

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file | No need
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from msmcconnell October 30, 2020 15:57
@@ -16,6 +16,4 @@

source /opt/ros/kinetic/setup.bash
cd ~/
export ROS_LANG_DISABLE=genjava # Disable genjava
catkin_make install -DCATKIN_BLACKLIST_PACKAGES="rosjava_utils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the catkin_make install line jut not the "-DCATKIN_BLACKLIST_PACKAGES="rosjava_utils"" part of it

@msmcconnell msmcconnell merged commit 6f54a16 into develop Oct 30, 2020
@msmcconnell msmcconnell deleted the feature/remove-java branch October 30, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants