Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerization of Scenario Runner CARLA Script #167

Closed
adamlm opened this issue Oct 27, 2023 · 0 comments · Fixed by #168
Closed

Dockerization of Scenario Runner CARLA Script #167

adamlm opened this issue Oct 27, 2023 · 0 comments · Fixed by #168
Assignees
Labels
enhancement New feature or request

Comments

@adamlm
Copy link
Contributor

adamlm commented Oct 27, 2023

Summary

Create docker image for running Scenario Runner script in cdasim repository. Image should include configurable CARLA host information.

Add scenario runner service description to carma-config xil cloud docker compose.

Related Jira story: CDAR-398

Reasoning for new functionality

No response

@adamlm adamlm added the enhancement New feature or request label Oct 27, 2023
@adamlm adamlm self-assigned this Oct 27, 2023
adamlm added a commit that referenced this issue Oct 27, 2023
The Docker image contains all necessary dependencies and embeds any
custom CARMA scenarios to run.
adamlm added a commit that referenced this issue Oct 27, 2023
adamlm added a commit that referenced this issue Oct 27, 2023
The scenario_runner.py script requires that the existing files in the
scenarios/ directory remain there. The installation script no longer
deletes them.
adamlm added a commit that referenced this issue Oct 27, 2023
adamlm added a commit that referenced this issue Oct 30, 2023
adamlm added a commit that referenced this issue Oct 31, 2023
It was causing CDASim to crash. It's not a big deal right now since we
are not using it in the MyScenario definition.
adamlm added a commit that referenced this issue Nov 1, 2023
The Dockerfile now downloads CARLA's Python API before installing the
CARMA ScenarioRunner scenarios. This allows Docker to cache the CARLA
download layer, reducing build times when developers want to
develop new scenarios.
MishkaMN pushed a commit to usdot-fhwa-stol/carma-config that referenced this issue Nov 2, 2023
# PR Details
## Description

This PR adds the ScenarioRunner container containing the CARMA
integration testing scenarios.

## Related Issue

Closes #278 
Closes [CDAR-453](https://usdot-carma.atlassian.net/browse/CDAR-453)

Related to usdot-fhwa-stol/cdasim#167

## Motivation and Context

Needed to have repeatable integration and regression tests.

## How Has This Been Tested?

Manually verified that CDASim launches with the `xil_cloud`
configuration.

## Types of changes

- [x] New feature (non-breaking change that adds functionality)

## Checklist:

- [x] I have read the **CONTRIBUTING** document.
[CARMA Contributing
Guide](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md)

[CDAR-453]:
https://usdot-carma.atlassian.net/browse/CDAR-453?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant