-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 Humble upgrade code only - not integration tested #166
Open
MishkaMN
wants to merge
67
commits into
develop-humble
Choose a base branch
from
arc-199-humble-upgrade
base: develop-humble
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+333
−231
Open
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
d23d398
initial humble change
MishkaMN ef9b4e9
circle ci to humble
MishkaMN fa5432f
dockerhub trigger for develop-humble
MishkaMN fa5ba3e
update source list
MishkaMN 9d07cb6
lexus to gem
MishkaMN b414252
fix install paths
MishkaMN c4e39fa
remove ros1 steps
MishkaMN 4d4c729
remove extra ros1
MishkaMN 2362824
make it most recent ros2
MishkaMN 568aa31
try make it faster
MishkaMN bdc0093
humble
MishkaMN 88dd9c4
add sensit9ve
MishkaMN f946615
replace checkouts to installs
MishkaMN c5cb881
split into noetic and humble
MishkaMN 9692ff8
Split noetic and humble
MishkaMN 69ae6f0
fix syntax
MishkaMN 5b8614a
rename access_token
MishkaMN ef63e1f
introduce tag replacing functionality
MishkaMN 6835b41
remove dependency from autoware
MishkaMN 233a93b
comment
MishkaMN eafb414
deps from autoware.ai
MishkaMN b8f80ba
Fix autoware checkout
MishkaMN 1429231
Fix messages
MishkaMN 180bbd8
Fix git checkout for ros1
MishkaMN 20473f3
Fix syntax error
MishkaMN b2e9e4d
Fix weird syntax
MishkaMN a6e5940
Be consistent in branching
MishkaMN f15e240
Add .git in the URL
MishkaMN 49a8052
Maybe authentication issue
MishkaMN 54b1b05
Try quoting
MishkaMN 90d88af
try hardcoding
MishkaMN d30a285
Enforce sequential
MishkaMN 8803720
rename to be specific
MishkaMN 91d0ed2
Make sudo
MishkaMN 2019a29
Try renaming the folder
MishkaMN 7ed2150
Try normal git clone
MishkaMN 38c66b0
Normal checkout
MishkaMN db6c85d
Use normal git clone
MishkaMN 0fa13ef
Check git version
MishkaMN fee082d
Try sparse again with different approach
MishkaMN 77fd049
Fix ROS1 issues
MishkaMN 5bda553
Add autoware_build_flags for ROS1
MishkaMN e91bdd6
Add ros_observer for ROS1
MishkaMN f47e53a
sudo issues locally
MishkaMN ea14fde
fix something that will break
MishkaMN 7836cde
Add back ssc_pm_lexus
MishkaMN 348a38d
Fix
MishkaMN 966452e
Fix docker stuff
MishkaMN 49a8747
Relax failure
MishkaMN dcfb1da
Optimize
MishkaMN 2ba0dbc
optimize ROS1 build
MishkaMN c2cd204
Make ROS1 Fail if didn't complete
MishkaMN 53efa7e
Remove incorrect requirement
MishkaMN ad3d224
Working version final
MishkaMN ac4026b
Fix CI failing
MishkaMN 31f04ed
Fix CI
MishkaMN 4142632
Install deps
MishkaMN 318a203
elevate privilege
MishkaMN 5cfe552
try apt instead of apt-get
MishkaMN 2bd7a52
add yes to commands
MishkaMN acb52d1
avoid interactiveness for all
MishkaMN 14d16ef
Rename to correct variable name SONAR_TOKEN
MishkaMN 0aa4025
Address PR
MishkaMN 7619aa3
remove extra change
MishkaMN 614ef00
Fix the github action branch
MishkaMN db14aeb
Try removing std_srvs from cpp
MishkaMN ac0fed2
remove std_srvs I missed
MishkaMN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Docker Humble build | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
docker: | ||
uses: usdot-fhwa-stol/actions/.github/workflows/docker.yml@main | ||
with: | ||
file: ./humble/Dockerfile | ||
tag_name_suffix: humble | ||
replace_suffix: true # TODO: remove after develop-humble branch is merged to develop | ||
secrets: | ||
GH_PAT: ${{ secrets.GH_PAT }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Docker Noetic build | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
docker: | ||
uses: usdot-fhwa-stol/actions/.github/workflows/docker.yml@main | ||
with: | ||
file: ./noetic/Dockerfile | ||
tag_name_suffix: noetic | ||
replace_suffix: true # TODO: remove after develop-humble branch is merged to develop | ||
secrets: | ||
GH_PAT: ${{ secrets.GH_PAT }} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: Docker Hub Noetic build | ||
|
||
on: | ||
push: | ||
branches: | ||
- develop | ||
- master | ||
- "release/*" | ||
- develop-humble | ||
tags: | ||
- "carma-system-*" | ||
jobs: | ||
dockerhub: | ||
uses: usdot-fhwa-stol/actions/.github/workflows/dockerhub.yml@main | ||
secrets: | ||
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | ||
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} | ||
TOKEN: ${{ secrets.GH_PAT }} | ||
with: | ||
file: ./noetic/Dockerfile | ||
tag_name_suffix: noetic | ||
replace_suffix: true # TODO: remove after develop-humble branch is merged to develop |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Copyright (C) 2018-2022 LEIDOS. | ||
# Copyright (C) 2025 LEIDOS. | ||
# | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be 2018-2025 |
||
# Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
# use this file except in compliance with the License. You may obtain a copy of | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,19 @@ | ||
#!/bin/bash | ||
|
||
# Copyright (C) 2018-2022 LEIDOS. | ||
# | ||
# Copyright (C) 2025 LEIDOS. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2018-2025 |
||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
# use this file except in compliance with the License. You may obtain a copy of | ||
# the License at | ||
# | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
# License for the specific language governing permissions and limitations under | ||
# the License. | ||
declare -i false=0 true=1 | ||
|
||
USERNAME=usdotfhwastol | ||
|
||
|
@@ -23,9 +24,28 @@ echo "" | |
echo "##### $IMAGE Docker Image Build Script #####" | ||
echo "" | ||
|
||
token="" | ||
build_ros1_pkgs="$false" | ||
build_ros2_pkgs="$false" | ||
dockerfile_dir="" | ||
|
||
while [[ $# -gt 0 ]]; do | ||
arg="$1" | ||
case $arg in | ||
-ros1|--ros1_build) | ||
dir=~/workspace_ros1 | ||
echo "Install and build ros1 packages" | ||
build_ros1_pkgs="$true" | ||
build_ros2_pkgs="$false" | ||
shift | ||
;; | ||
-ros2|--ros2_build) | ||
dir=~/workspace_ros2 | ||
echo "Install and build ros2 packages" | ||
build_ros1_pkgs="$false" | ||
build_ros2_pkgs="$true" | ||
shift | ||
;; | ||
-v|--version) | ||
COMPONENT_VERSION_STRING="$2" | ||
shift | ||
|
@@ -45,9 +65,7 @@ while [[ $# -gt 0 ]]; do | |
shift | ||
;; | ||
*) ##Arguments for ssc_pm_lexus | ||
access_id=${arg} | ||
secret_key="$2" | ||
shift | ||
token="$1" | ||
shift | ||
;; | ||
esac | ||
|
@@ -61,34 +79,33 @@ echo "Building docker image for $IMAGE version: $COMPONENT_VERSION_STRING" | |
echo "Final image name: $USERNAME/$IMAGE:$COMPONENT_VERSION_STRING" | ||
|
||
# Get arguments for ssc_pm_lexus | ||
if [ -z $access_id ]; | ||
then | ||
echo "No argument provided for access_id, this script needs to be run with <ACCESS_ID> <SECRET_KEY>" | ||
exit 1 | ||
fi | ||
|
||
if [ -z $secret_key ]; | ||
then | ||
echo "No argument provided for secret_key, this script needs to be run with <ACCESS_ID> <SECRET_KEY>" | ||
|
||
if [[ $build_ros1_pkgs -eq 1 ]]; then | ||
cd ../noetic | ||
echo "======= ROS1 build selected ========" | ||
elif [[ $build_ros2_pkgs -eq 1 ]]; then | ||
cd ../humble | ||
if [ -z $token ]; then | ||
echo "No argument provided for token for ROS2 build, this script needs to be run with <TOKEN>" | ||
exit 1 | ||
fi | ||
echo "======= ROS2 build selected ========" | ||
fi | ||
|
||
cd .. | ||
if [[ $COMPONENT_VERSION_STRING = "develop" ]]; then | ||
sed "s|usdotfhwastoldev/|$USERNAME/|g; s|usdotfhwastolcandidate/|$USERNAME/|g; s|usdotfhwastol/|$USERNAME/|g; s|:[0-9]*\.[0-9]*\.[0-9]*|:$COMPONENT_VERSION_STRING|g; s|checkout.bash|checkout.bash -d|g" \ | ||
Dockerfile | docker build --network=host -f - --no-cache -t $USERNAME/$IMAGE:$COMPONENT_VERSION_STRING \ | ||
Dockerfile | docker build --network=host -f - -t $USERNAME/$IMAGE:$COMPONENT_VERSION_STRING \ | ||
--build-arg VERSION="$COMPONENT_VERSION_STRING" \ | ||
--build-arg VCS_REF=`git rev-parse --short HEAD` \ | ||
--build-arg BUILD_DATE=`date -u +”%Y-%m-%dT%H:%M:%SZ”` \ | ||
--build-arg ACCESS_ID=$access_id \ | ||
--build-arg SECRET_KEY=$secret_key . | ||
--build-arg TOKEN=$token ../ | ||
else | ||
docker build --network=host --no-cache -t $USERNAME/$IMAGE:$COMPONENT_VERSION_STRING \ | ||
docker build --network=host -f Dockerfile -t $USERNAME/$IMAGE:$COMPONENT_VERSION_STRING \ | ||
--build-arg VERSION="$COMPONENT_VERSION_STRING" \ | ||
--build-arg VCS_REF=`git rev-parse --short HEAD` \ | ||
--build-arg BUILD_DATE=`date -u +”%Y-%m-%dT%H:%M:%SZ”` \ | ||
--build-arg ACCESS_ID=$access_id \ | ||
--build-arg SECRET_KEY=$secret_key . | ||
--build-arg TOKEN=$token ../ | ||
fi | ||
|
||
TAGS=() | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright should be 2018-2022