Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more flexibility in encoding georeference inside map.osm #99

Merged
merged 1 commit into from
May 8, 2020

Conversation

MishkaMN
Copy link

@MishkaMN MishkaMN commented May 7, 2020

PR Details

Description

Added more flexibility in encoding geoReference string inside vector_map.osm.
Autoware_osm_parsert now supports following geoReference tags in the map, e.g.:

  • <geoReference>+proj=tmerc +lat_0=39.46636844371259 +lon_0=-76.16919523566943 +k=1 +x_0=0 +y_0=0 +datum=WGS84</geoReference>

  • <geoReference v="+proj=tmerc +lat_0=39.46636844371259 +lon_0=-76.16919523566943 +k=1 +x_0=0 +y_0=0 +datum=WGS84"/>

  • <geoReference value="+proj=tmerc +lat_0=39.46636844371259 +lon_0=-76.16919523566943 +k=1 +x_0=0 +y_0=0 +datum=WGS84"/>

Related Issue

Initial issue is here

Motivation and Context

Initial way of encoding, which is to use inside-brackets approach, was not as common, and created confusion for developers when they used more common practices without being successfully loading the map. Particularly, this creates discrepancy when scripts like osm converter is used.

How Has This Been Tested?

Unit Tested using sample maps

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from itabrl May 7, 2020 23:13
@MishkaMN MishkaMN self-assigned this May 7, 2020
itabr
itabr approved these changes May 8, 2020
@itabrl itabrl merged commit 10fdfc9 into carma-develop May 8, 2020
@MishkaMN MishkaMN deleted the fix/georeference branch May 21, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants