Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Version to 4.5.0 #266

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Update Version to 4.5.0 #266

merged 2 commits into from
Apr 9, 2024

Conversation

paulbourelly999
Copy link

@paulbourelly999 paulbourelly999 commented Apr 9, 2024

PR Details

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    @MishkaMN

@@ -6,7 +6,6 @@ on:
- "carma-develop"
- "master"
- "release/*"
- "release/lavida"
jobs:
dockerhub:
runs-on: ubuntu-latest-8-cores
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 28 needs to change, it has candidate info:
tags: usdotfhwastolcandidate/${{ github.event.repository.name }}:lavida

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line is just plain incorrect. I replaced it with dockerhub stol action. This is mostly duplication from our dockerhub automated builds. It looks like for autoware.ai we use dockerhub automated builds for everything. GitHub actions is faster than dockerhub automated builds. I can either do these changes or remove the file all together. We are eventually going to move from dockerhub automated builds to Github action so I figured the current change is best.

@paulbourelly999 paulbourelly999 requested a review from MishkaMN April 9, 2024 19:35
@MishkaMN MishkaMN merged commit 07e0577 into release/lavida Apr 9, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants