refactor: Tweak generated Dispose(bool) to make #8688 less common
#8854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss common - avoid generating disable `Dispose` code for Android - inline `RequestCollect` method (if only to reduce metadata) - reuse the `Count` check to avoid the enumerator (iOS) - use the macOS r/w `Subviews` property to avoid multiple native calls
|
|
MartinZikmund
approved these changes
May 23, 2022
|
perhaps it is better to add a comment with reference at the issue. |
Both (Uno and Xamarin) issues are in the PR comments, but you likely mean in the source code, right ? If so that will be part of the 2nd PR - which is meant to be reverted once the Xamarin runtime bug is fixed. The changes inside this (1st) PR should remain even after the fix 😄 |
6 tasks
|
I think it is always better to add a comment in the code when the changes are not obvious to avoid regressions. From the tests I have made, this PR also fix issue #8682 |
6 tasks
|
Nice improvement, indeed! This will avoid doing too much work on tree leaves. Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disposecode for AndroidRequestCollectmethod (if only to reduce metadata)Countcheck to avoid the enumerator (iOS)Subviewsproperty to avoid multiple native callsGitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
Refactoring (no functional changes, no api changes)
What is the current behavior?
Applications can display warnings like
Tried to create a managed reference from an object that already has a managed reference, see #8688What is the new behavior?
This warning should not be seen, on macOS, with the changes included in the PR as it avoid the
RemoveFromSuperviewcall, inside with Xamarin.Mac would callSuperviewand expose a bug inside the Xamarin runtime leading to the warning.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
This first PR set the stage to fix #8688 [1] (in a subsequent PR). This
is splitted into a few PRs so Uno's local fix can be removed once the
issue is fixed inside Xamarin SDKs.
This also includes a workaround (for macOS only) to the Xamarin
runtime resurfacing bug [2] - because Xamarin.Mac's
RemoveFromSubviewshas custom code that calls the
Superviewmethod.[1] #8688
[2] xamarin/xamarin-macios#15089
Internal Issue (If applicable):