fix(WebView): [macOs] [WKNavigationAction userActivity]: unrecognized… selector sent to instance #8683
Conversation
… selector sent to instance
|
|
| @@ -838,6 +838,21 @@ public override void DidFailProvisionalNavigation(WKWebView webView, WKNavigatio | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public override void DecidePolicy(WKWebView webView, WKNavigationAction navigationAction, WKWebpagePreferences preferences, Action<WKNavigationActionPolicy, WKWebpagePreferences> decisionHandler) | |||
There was a problem hiding this comment.
Should we be invoking back this method:
It's curious that we have not seen this before on iOS.
To limit the impact, I'd suggest to keep this method macOS specific for now.
It may override/interact the behavior for the other ?
There was a problem hiding this comment.
I'm just starting out with the Apple world. Based on the documentation found here, if it is not implemented, the runtime calls webView: decidePolicyForNavigationAction: decisionHandler :.
I tried to copy the DecidePolicy logic to this overload and the problem persists. So the problem is in DecidePolicy which does not implement the specific case, not for the missing of the overaide of the olverload.
There was a problem hiding this comment.
@jeromelaban the issue is present only on c.i.. Do you have any idea what this might depend on?
There was a problem hiding this comment.
Which issue are you mentioning?
There was a problem hiding this comment.
I see, I missed that part. Yes, so those issues are generally happening when the managed object has been collected, but the native instance still wants to interact with it. This generally means that the target instance is not rooted properly in the class that created the instance.
|
fixed by #8854 |
workgroupengineering
deleted the
fixes/SemplesApp/macOS/WebView/unrecognized-selector
branch
GitHub Issue (If applicable): closes #8682
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):