Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: upgrade consola to v3 and minimum node version #128

Merged
merged 3 commits into from
Nov 17, 2023
Merged

chore(deps)!: upgrade consola to v3 and minimum node version #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd0641
fix: bump consola to 3.x to align with other nuxt 2 packages
rchl Nov 16, 2023
b313e60
bump node in ci
rchl Nov 17, 2023
b97c0cf
bump to 14.18.0
rchl Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
cache: yarn
- run: yarn install
- run: yarn prepack
- run: yarn lint
- run: npx node@12 ./node_modules/.bin/mocha ./test/*.test.*
- run: npx node ./node_modules/.bin/mocha ./test/*.test.*
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"dependencies": {
"chalk": "^4.1.2",
"consola": "^2.15.3",
"consola": "^3.2.3",
"pretty-time": "^1.1.0",
"std-env": "^3.3.3"
},
Expand All @@ -50,6 +50,6 @@
"webpack": "3 || 4 || 5"
},
"engines": {
"node": ">=v12.22.12"
"node": ">=14.18.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we might upgrade to higher version in next major, will have to check other deps)

}
}
2 changes: 1 addition & 1 deletion src/reporters/basic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { consola } from '../utils/cli'
import { Reporter } from 'src/types'
import { Reporter } from '../types'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change necessary?

Copy link
Contributor Author

@rchl rchl Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused error in the editor:

Screenshot 2023-11-17 at 11 40 45

If you insist then I can look into fixing that differently (probably a missing mapping or baseDir in tsconfig) but I thought it's better to be consistent and use paths relative to the current file anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this change doesn't affect compiled bundle, as far as I can tell, so IMO keeping this change is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is better (hate old me that didn't used relative haha) only preferred that if it was not part of this commit but also okay 👍🏼


export default class SimpleReporter implements Reporter {
start (context) {
Expand Down
2 changes: 1 addition & 1 deletion src/reporters/fancy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { renderBar, colorize, ellipsisLeft } from '../utils/cli'
import { formatRequest } from '../utils/webpack'
import { BULLET, TICK, CROSS, CIRCLE_OPEN } from '../utils/consts'
import LogUpdate from '../utils/log-update'
import { Reporter } from 'src/types'
import { Reporter } from '../types'

const logUpdate = new LogUpdate()

Expand Down
2 changes: 1 addition & 1 deletion src/reporters/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import chalk from 'chalk'

import { colorize } from '../utils/cli'
import Profiler from '../profiler'
import { Reporter } from 'src/types'
import { Reporter } from '../types'

export default class ProfileReporter implements Reporter {
progress (context) {
Expand Down
2 changes: 1 addition & 1 deletion src/reporters/stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Reporter } from 'src/types'
import { Reporter } from '../types'

export default class StatsReporter implements Reporter {
private options: any
Expand Down
2 changes: 1 addition & 1 deletion src/utils/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import chalk from 'chalk'
import _consola from 'consola'
import { consola as _consola } from 'consola'
import { markdownTable } from 'markdown-table'

import { BLOCK_CHAR, BLOCK_CHAR2, BAR_LENGTH } from './consts'
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,11 @@ consola@^2.15.3:
resolved "https://registry.yarnpkg.com/consola/-/consola-2.15.3.tgz#2e11f98d6a4be71ff72e0bdf07bd23e12cb61550"
integrity sha512-9vAdYbHj6x2fLKC4+oPH0kFzY/orMZyG2Aj+kNylHxKGJ/Ed4dpNyAQYwJOdqO4zdM7XpVHmyejQDcQHrnuXbw==

consola@^3.2.3:
version "3.2.3"
resolved "https://registry.yarnpkg.com/consola/-/consola-3.2.3.tgz#0741857aa88cfa0d6fd53f1cff0375136e98502f"
integrity sha512-I5qxpzLv+sJhTVEoLYNcTW+bThDCPsit0vLNKShZx6rLtpilNpmmeTPaeqJb9ZE9dV3DGaeby6Vuhrw38WjeyQ==

conventional-changelog-angular@^5.0.12:
version "5.0.13"
resolved "https://registry.yarnpkg.com/conventional-changelog-angular/-/conventional-changelog-angular-5.0.13.tgz#896885d63b914a70d4934b59d2fe7bde1832b28c"
Expand Down