chore(deps)!: upgrade consola to v3 and minimum node version #128
Conversation
|
Bumped node in CI to 16. Maybe it will fix it. The package specifies 12.22.12 as minimum version in |
pi0
changed the title
pi0
changed the title
pi0
changed the title
| @@ -50,6 +50,6 @@ | |||
| "webpack": "3 || 4 || 5" | |||
| }, | |||
| "engines": { | |||
| "node": ">=v12.22.12" | |||
| "node": ">=14.18.0" | |||
There was a problem hiding this comment.
(we might upgrade to higher version in next major, will have to check other deps)
| @@ -1,5 +1,5 @@ | |||
| import { consola } from '../utils/cli' | |||
| import { Reporter } from 'src/types' | |||
| import { Reporter } from '../types' | |||
There was a problem hiding this comment.
Caused error in the editor:
If you insist then I can look into fixing that differently (probably a missing mapping or baseDir in tsconfig) but I thought it's better to be consistent and use paths relative to the current file anyway.
There was a problem hiding this comment.
Also this change doesn't affect compiled bundle, as far as I can tell, so IMO keeping this change is better.
There was a problem hiding this comment.
Yeah it is better (hate old me that didn't used relative haha) only preferred that if it was not part of this commit but also okay 👍🏼
|
@rchl I might need to delay this release to next week as have some priorities. If it is a blocker for something, please mention. (and thanks for PR) |
|
No, not a blocker. Thanks. |
🔗 Linked issue
nuxt/nuxt#24343
❓ Type of change
📚 Description
Addressing the nuxt/nuxt#24343 issue which is about outdated
consolabeing used in a couple of Nuxt 2 packages.📝 Checklist