Introduce borrowed variants of normalizer structs #5413
Conversation
hsivonen
added
C-collator
|
I had the wrong assumption of how |
| @@ -89,6 +90,49 @@ impl CanonicalComposition { | |||
| /// | |||
| /// [📚 Help choosing a constructor](icu_provider::constructors) | |||
| #[cfg(feature = "compiled_data")] | |||
| pub const fn new() -> Self { | |||
There was a problem hiding this comment.
For existing borrowed types we use Owned::new() -> Borrowed. This keeps the constructors together. I think we should discuss if that's what we want to do, but for now do it for consistency.
There was a problem hiding this comment.
I'm warming up to the idea that it should be Borrowed::new() because we might want to be able to cfg-out the whole owned class at some point.
There was a problem hiding this comment.
I'll let @robertbastian review in detail since he's most familiar with the owned/borrowed compiled data architecture and is in the correct time zone, but from a drive-by, this looks quite good!
|
I pushed a |
|
|
Addresses #5187 for the normalizer.
HarfBuzz deliberately out of scope for this PR.