Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce borrowed versions of segmenter types #5514

Open
hsivonen opened this issue Sep 6, 2024 · 0 comments
Open

Introduce borrowed versions of segmenter types #5514

hsivonen opened this issue Sep 6, 2024 · 0 comments
Assignees
@Manishearth
Labels
2.0-breaking Changes that are breaking API changes C-segmentation Component: Segmentation S-small Size: One afternoon (small bug fix or enhancement)
Milestone
ICU4X 2.0 Stretch...

Comments

@hsivonen
Copy link
Member

hsivonen commented Sep 6, 2024

By code inspection, issue #5187 seems applicable to the segmenters as well. To optimize away .get() on DataPayload in the baked data case, please introduce borrowed versions of the segmented types (similar to #5513 and #5413).
@hsivonen hsivonen added C-segmentation Component: Segmentation 2.0-breaking Changes that are breaking API changes labels Sep 6, 2024
@hsivonen hsivonen mentioned this issue Jan 14, 2025
Open
@Manishearth Manishearth added the S-small Size: One afternoon (small bug fix or enhancement) label Jan 15, 2025
@Manishearth Manishearth self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
2.0-breaking Changes that are breaking API changes C-segmentation Component: Segmentation S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

No branches or pull requests
2 participants
@hsivonen @Manishearth