Skip to content

Commit

Permalink
🩹 layouts(navigation): Remove hyperlink on site logo (#167)
Browse files Browse the repository at this point in the history
Fixes #157.

* removed hyperlink for unicef logo

* 🐛 layouts(navigation): Remove extraneous HTML, simplify CSS classes

This commit removes the added `<p>` tag, which added extra padding and
spacing between the logo and site title. It takes the `navbar-brand`
class and applies it to the whole `<div>` while moving the `text-center`
class into the site title, so the spacing appears correctly.

This also removes competing CSS classes, simplifying debugging later.

Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>

Signed-off-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
Co-authored-by: Justin W. Flory (he/him) [UNICEF Innovation] <jflory@unicef.org>
  • Loading branch information
Neha9849 and jwflory authored Aug 19, 2022
1 parent 3992cb4 commit ca5ffbe
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions layouts/partials/navigation.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
{{ $orgName:= site.Params.brand.parent_org_name }}
{{ $orgUrl:= site.Params.brand.parent_org_url }}

<div class="text-center">
<a class="navbar-brand" href="{{ if $logo }}{{ $orgUrl }}{{ else }}{{ site.BaseURL | relLangURL }}{{ end }}">
<div class="navbar-brand">
{{ if $logo }}
<img class="img-fluid d-inline globalLogoImg"
src="{{ $logo | absURL }}"
alt="{{ site.Title }}">
</a>
{{ end }}
<a class="navbar-brand text-white d-block px-1" href="{{ site.BaseURL | relLangURL }}">{{ site.Title }}</a>
<a class="text-center text-white d-block px-1" href="{{ site.BaseURL | relLangURL }}">{{ site.Title }}</a>
</div>

</div>
Expand Down

0 comments on commit ca5ffbe

Please sign in to comment.