Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a reader, I want to go the home page on clicking on the unicef logo. #157

Closed
Neha9849 opened this issue Aug 13, 2022 · 1 comment · Fixed by #167
Closed

As a reader, I want to go the home page on clicking on the unicef logo. #157

Neha9849 opened this issue Aug 13, 2022 · 1 comment · Fixed by #167
Assignees
@Neha9849
Labels
C: design thinking Planning and creative thinking about design elements in new features or improvements T: bug Something isn't working

Comments

@Neha9849
Copy link
Member

Summary

User reviews in testing:

  • Clicking UNICEF logo takes you to UNICEF website; clicking on either should go to the same page (i.e. O.S. Inventory)
  • UNICEF.org redirect from top logo was confusing!

Priority

primary

Category

front-end

Type

functional
@Neha9849 Neha9849 added ?: needs triage Metadata needs to be triaged and updated C: design thinking Planning and creative thinking about design elements in new features or improvements labels Aug 13, 2022
@jwflory jwflory added T: bug Something isn't working and removed ?: needs triage Metadata needs to be triaged and updated labels Aug 15, 2022
@jwflory jwflory moved this from Backlog to Current sprint in Open Source @ OoI Ventures Aug 15, 2022
@jwflory jwflory mentioned this issue Aug 15, 2022
Open
@jwflory
Copy link
Member

jwflory commented Aug 15, 2022 •
edited
Loading

Remove the <a> attribute from the logo so it is no longer clickable.

https://github.com/unicef/inventory-hugo-theme/blob/main/layouts/partials/navigation.html#L9

@Neha9849 Neha9849 mentioned this issue Aug 19, 2022
Merged
@Neha9849 Neha9849 moved this from Current sprint to Pending review in Open Source @ OoI Ventures Aug 19, 2022
Repository owner moved this from Pending review to Done in Open Source @ OoI Ventures Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neha9849 Neha9849

Labels
C: design thinking Planning and creative thinking about design elements in new features or improvements T: bug Something isn't working
Projects
Open Source @ OoI Ventures
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed hyperlink for unicef logo Neha9849/inventory-hugo-theme
2 participants
@jwflory @Neha9849